Review main Merged

63559[TASK] Use PSR-7 Request in BackendController

Benni Mack CR +2 V +2 Easy +25 −12 updated 03/06/20, 09:10

Commit message

Various GeneralUtility::_GET() calls are now replaced by
using the PSR-7 Request object, reducing the need for accessing
global scope variables $_GET and $_POST.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1214

  1. Benni Mack uploaded patch set 1 03/06/20, 07:36

  2. TYPO3com voted on patch set 1 V -1 03/06/20, 07:47 Completed build in 10m 55s on Fri, 6 Mar, 07:47 AM Test Summary: 6 of 72604 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1004

  3. Benni Mack commented on patch set 2 03/06/20, 07:51

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 03/06/20, 08:10 Completed build in 19m 06s on Fri, 6 Mar, 08:10 AM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1009

  5. Oli Bartsch voted on patch set 2 CR +1 03/06/20, 08:20

  6. Susi Moog voted on patch set 2 CR +1 03/06/20, 08:32

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 03/06/20, 08:38

  8. Andreas Kienast commented on patch set 2 03/06/20, 08:39

    UriBuilder.php:147

    FYI: this branch is entered in DashboardController::configureDashboardAction(), when a configuration is saved.
  9. Benni Mack commented on patch set 2 03/06/20, 08:50

    UriBuilder.php:147 Reply

    I don't understand that sentence... :(
  10. Andreas Kienast commented on patch set 2 03/06/20, 08:55

    UriBuilder.php:147 Reply Unresolved

    Yeah, I didn't express myself properly. This was just a hint for other reviewers under which circumstances a breakpoint here is hit ;)
  11. Oli Bartsch voted on patch set 2 V +1 03/06/20, 09:07

  12. Benni Mack voted on patch set 2 V +2 CR +2 03/06/20, 09:10

  13. Benni Mack merged patch set 3 03/06/20, 09:10

  14. Oliver Klee commented on patch set 3 03/06/20, 09:10

    BackendController.php:182 Unresolved

    The order of type and name is switched here. The type needs to come first. (I propose we drop the signature-related PHPDoc annotations from the this method altogether, though, as they do not add anything over the existing type declarations.)