Review main Merged

63561[TASK] Improve php doc block for better static code analysis

Alexander Schnitzler CR +2 V +2 Hard +391 −34 updated 03/15/20, 11:24

Commit message

This commit adds missing doc blocks and missing type
hints to existing doc blocks to help static code
analyzers like phpstan do a better job.
Also, wrong type hints have been changed.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 58

Show 38 more files

Review log 1824

  1. Alexander Schnitzler uploaded patch set 1 03/06/20, 11:33

  2. TYPO3com voted on patch set 1 V -1 03/06/20, 11:34 Completed build in 31s on Fri, 6 Mar, 11:34 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1014

  3. Alexander Schnitzler uploaded patch set 2 03/06/20, 11:35

  4. TYPO3com voted on patch set 2 V -1 03/06/20, 11:45 Completed build in 10m 17s on Fri, 6 Mar, 11:45 AM Test Summary: 72069 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1015

  5. Alexander Schnitzler uploaded patch set 3 03/06/20, 11:50

  6. TYPO3com voted on patch set 3 V +1 03/06/20, 12:00 Completed build in 10m 27s on Fri, 6 Mar, 12:00 PM Test Summary: 72069 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1016

  7. Alexander Schnitzler uploaded patch set 4 03/06/20, 12:18

  8. TYPO3com voted on patch set 4 V +1 03/06/20, 12:30 Completed build in 12m 22s on Fri, 6 Mar, 12:30 PM Test Summary: 72069 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1018

  9. Roland Golla commented on patch set 4 CR +1 03/06/20, 14:26

    All new doctypes looks good for me
  10. Oliver Klee commented on patch set 4 CR +1 03/06/20, 14:27

    <3
  11. Alexander Schnitzler uploaded patch set 5 03/09/20, 08:42

  12. Alexander Schnitzler wrote 03/09/20, 08:43

    Description set to "manual rebase"
  13. TYPO3com voted on patch set 5 V +1 03/09/20, 08:54 Completed build in 11m 40s on Mon, 9 Mar, 08:54 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1162

  14. Daniel Goerz commented on patch set 5 03/09/20, 09:04

    MetaTagManagerRegistry.php:32

    At most places in core we have an empty line between a property and the doc block of the next one.
  15. Alexander Schnitzler commented on patch set 5 CR -1 03/09/20, 09:28

    MetaTagManagerRegistry.php:32 Reply

    Ack, will adjust that.
  16. Alexander Schnitzler rebased onto patch set 6 03/11/20, 08:38

  17. Alexander Schnitzler uploaded patch set 7 03/11/20, 08:41

  18. Alexander Schnitzler uploaded patch set 8 03/11/20, 08:42

  19. TYPO3com voted on patch set 8 V +1 03/11/20, 09:03 Completed build in 17m 15s on Wed, 11 Mar, 09:03 AM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1253

  20. Oliver Klee voted on patch set 8 CR +1 03/11/20, 09:15

  21. Susi Moog voted on patch set 8 CR +1 03/15/20, 11:13

  22. Susi Moog voted on patch set 8 V +1 03/15/20, 11:16

  23. Daniel Goerz voted on patch set 8 V +2 CR +2 03/15/20, 11:24

  24. Daniel Goerz merged patch set 9 03/15/20, 11:24