63564[BUGFIX] Use correct variable in TcaInline in exception log
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Guido Schmechel +1
- Alexander Schnitzler +1
- Mathias Brodala +1
-
Verified V +2 Done
- Benni Mack +2
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1113
-
Andreas Kienast uploaded patch set 1 03/06/20, 13:28
-
Christian Eßl voted on patch set 1 CR +1 03/06/20, 13:30
-
Alexander Schnitzler voted on patch set 1 V +1 CR +1 03/06/20, 13:31
-
Mathias Brodala commented on patch set 1 CR -1 03/06/20, 13:33
This is not necessary for 8.7 since there the structure is different and the mentioned variable exists: https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_8-7/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php#L232 https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_8-7/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php#L241 -
Andreas Kienast commented on patch set 1 03/06/20, 13:35
Reply Unresolved
You're right, then some refactoring broke this. -
Andreas Kienast updated the commit message in patch set 2 03/06/20, 13:35
-
Mathias Brodala voted on patch set 2 CR +1 03/06/20, 13:36
-
TYPO3com voted on patch set 1 V -1 03/06/20, 13:38 Completed build in 10m 29s on Fri, 6 Mar, 01:38 PM Test Summary: 71773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1027
-
Alexander Schnitzler voted on patch set 2 V +1 CR +1 03/06/20, 13:41
-
Guido Schmechel voted on patch set 2 CR +1 03/06/20, 13:43
-
TYPO3com voted on patch set 2 V +1 03/06/20, 13:47 Completed build in 11m 13s on Fri, 6 Mar, 01:47 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1029
-
Benni Mack voted on patch set 2 V +2 CR +2 03/06/20, 14:12
-
Andreas Kienast merged patch set 3 03/06/20, 14:13