Review main Merged

63564[BUGFIX] Use correct variable in TcaInline in exception log

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 03/06/20, 14:13

Commit message

To log the exception properly, the variable `$defaultLanguageUid` is now
used instead of the undefined `$localizedUid`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • Alexander Schnitzler +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Andreas Kienast uploaded patch set 1 03/06/20, 13:28

  2. Christian Eßl voted on patch set 1 CR +1 03/06/20, 13:30

  3. Alexander Schnitzler voted on patch set 1 V +1 CR +1 03/06/20, 13:31

  4. Mathias Brodala commented on patch set 1 CR -1 03/06/20, 13:33

  5. Andreas Kienast commented on patch set 1 03/06/20, 13:35

    Reply Unresolved

    You're right, then some refactoring broke this.
  6. Andreas Kienast updated the commit message in patch set 2 03/06/20, 13:35

  7. Mathias Brodala voted on patch set 2 CR +1 03/06/20, 13:36

  8. TYPO3com voted on patch set 1 V -1 03/06/20, 13:38 Completed build in 10m 29s on Fri, 6 Mar, 01:38 PM Test Summary: 71773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1027

  9. Alexander Schnitzler voted on patch set 2 V +1 CR +1 03/06/20, 13:41

  10. Guido Schmechel voted on patch set 2 CR +1 03/06/20, 13:43

  11. TYPO3com voted on patch set 2 V +1 03/06/20, 13:47 Completed build in 11m 13s on Fri, 6 Mar, 01:47 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1029

  12. Benni Mack voted on patch set 2 V +2 CR +2 03/06/20, 14:12

  13. Andreas Kienast merged patch set 3 03/06/20, 14:13