Review main Merged

63565[TASK] Set phpstan level to 1

Alexander Schnitzler CR +2 V +2 Easy +13 −1 updated 03/06/20, 16:29

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Alexander Schnitzler uploaded patch set 1 03/06/20, 14:20

  2. TYPO3com voted on patch set 1 V -1 03/06/20, 14:31 Completed build in 10m 40s on Fri, 6 Mar, 02:31 PM Test Summary: 2 of 71741 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1031

  3. Oliver Klee voted on patch set 1 CR +1 03/06/20, 14:31

  4. Oliver Klee commented on patch set 1 03/06/20, 14:34

    The two build errors seem to be unrelated.
  5. TYPO3com voted on patch set 1 V +1 03/06/20, 14:51 Completed build in 41m 51s on Fri, 6 Mar, 02:51 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1031

  6. Daniel Goerz voted on patch set 1 V +1 CR +1 03/06/20, 15:44

  7. Andreas Kienast voted on patch set 1 V +2 CR +2 03/06/20, 16:29

  8. Andreas Kienast merged patch set 2 03/06/20, 16:29