63567[BUGFIX] Ask user for notifications before requesting permissions
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Andreas Kienast +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1931
Show 46 earlier messages
-
Frank Nägler uploaded patch set 1 03/06/20, 15:55
-
Susi Moog updated the commit message in patch set 2 03/06/20, 15:57
-
TYPO3com voted on patch set 1 V +1 03/06/20, 16:05 Completed build in 10m 19s on Fri, 6 Mar, 04:05 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1041
-
Andreas Kienast commented on patch set 2 03/06/20, 16:07
-
Susi Moog uploaded patch set 3 03/06/20, 16:08
-
TYPO3com voted on patch set 2 V +1 03/06/20, 16:09 Completed build in 11m 23s on Fri, 6 Mar, 04:09 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1042
-
Oli Bartsch commented on patch set 3 03/06/20, 16:10
locallang_mod_web_list.xlf:187UnresolvedMy suggestion: >> We always try to help you by sending important notifications, e.g. when your login expires. To be able to do this, we need your permission first. Therefore please click "Yes" and answer the security question of your browser with "allow". If you don't like to receive any notifications, just choose "No" and we won't ask again. << -
Andreas Kienast uploaded patch set 4 03/06/20, 16:16
-
TYPO3com voted on patch set 3 V +1 03/06/20, 16:18 Completed build in 09m 59s on Fri, 6 Mar, 04:18 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1043
-
TYPO3com voted on patch set 4 V +1 03/06/20, 16:26 Completed build in 10m 01s on Fri, 6 Mar, 04:26 PM Test Summary: 72070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1044
-
Andreas Kienast rebased onto patch set 5 03/06/20, 16:33
-
Andreas Kienast uploaded patch set 6 03/06/20, 16:33
-
Andreas Kienast uploaded patch set 7 03/06/20, 16:33
-
TYPO3com voted on patch set 5 V +1 03/06/20, 16:45 Completed build in 11m 35s on Fri, 6 Mar, 04:45 PM Test Summary: 72070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1046
-
TYPO3com voted on patch set 6 V -1 03/06/20, 16:48 Completed build in 15m 02s on Fri, 6 Mar, 04:48 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1047
-
TYPO3com voted on patch set 7 V -1 03/06/20, 16:51 Completed build in 15m 23s on Fri, 6 Mar, 04:51 PM Test Summary: 1 of 72556 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1048
-
TYPO3com voted on patch set 7 V +1 03/06/20, 16:53 Completed build in 33m 26s on Fri, 6 Mar, 04:53 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1048
-
Susi Moog updated the commit message in patch set 8 03/06/20, 16:53
-
TYPO3com voted on patch set 8 V +1 03/06/20, 17:04 Completed build in 10m 37s on Fri, 6 Mar, 05:04 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1049
-
Susi Moog voted on patch set 8 V +1 CR +1 03/07/20, 09:38
-
Benni Mack commented on patch set 8 03/07/20, 10:59
hmm, the UC setting is bound to the user, whereas the modal confirmation would be bound to the browser (so this could be put into LocalStorage instead?) -
Benni Mack updated the commit message in patch set 9 03/07/20, 14:02
-
TYPO3com voted on patch set 9 V +1 03/07/20, 14:13 Completed build in 11m 00s on Sat, 7 Mar, 02:13 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1082
-
Frank Nägler commented on patch set 9 CR -1 03/13/20, 20:39
> Patch Set 8: > > hmm, the UC setting is bound to the user, whereas the modal confirmation would be bound to the browser (so this could be put into LocalStorage instead?) totally right, I will update the patch -
Frank Nägler uploaded patch set 10 03/13/20, 20:46
-
TYPO3com voted on patch set 10 V -1 03/13/20, 21:18 Completed build in 19m 33s on Fri, 13 Mar, 09:18 PM Test Summary: 1 of 72685 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1336
-
TYPO3com voted on patch set 10 V +1 03/13/20, 21:29 Completed build in 50m 06s on Fri, 13 Mar, 09:29 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1336
-
Susi Moog voted on patch set 10 V +1 CR +1 03/15/20, 10:29
-
Benni Mack voted on patch set 10 CR +2 03/19/20, 11:56
-
Andreas Kienast voted on patch set 10 V +2 CR +2 03/20/20, 06:25
-
Andreas Kienast merged patch set 11 03/20/20, 06:25
LoginRefresh.ts:71Unresolved