Review main Merged

63567[BUGFIX] Ask user for notifications before requesting permissions

Frank Nägler CR +2 V +2 Easy +44 −3 updated 03/20/20, 06:25

Commit message

Since Firefox 72 a user interaction is required to prompt the user for native
browser notification permissions. This should prevent the user for
notification SPAM.

This patch introduces a modal confirmation, to get this user interaction.
The user is asked only once (as before), this is possible because the
modal is triggered only if a UC setting is not present.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1931

Show 46 earlier messages
  1. Frank Nägler uploaded patch set 1 03/06/20, 15:55

  2. Susi Moog updated the commit message in patch set 2 03/06/20, 15:57

  3. TYPO3com voted on patch set 1 V +1 03/06/20, 16:05 Completed build in 10m 19s on Fri, 6 Mar, 04:05 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1041

  4. Andreas Kienast commented on patch set 2 03/06/20, 16:07

    LoginRefresh.ts:71 Unresolved

    $confirm is not required
  5. Susi Moog uploaded patch set 3 03/06/20, 16:08

  6. TYPO3com voted on patch set 2 V +1 03/06/20, 16:09 Completed build in 11m 23s on Fri, 6 Mar, 04:09 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1042

  1. Oli Bartsch commented on patch set 3 03/06/20, 16:10

    locallang_mod_web_list.xlf:187 Unresolved

    My suggestion: >> We always try to help you by sending important notifications, e.g. when your login expires. To be able to do this, we need your permission first. Therefore please click "Yes" and answer the security question of your browser with "allow". If you don't like to receive any notifications, just choose "No" and we won't ask again. <<
  2. Andreas Kienast uploaded patch set 4 03/06/20, 16:16

  3. TYPO3com voted on patch set 3 V +1 03/06/20, 16:18 Completed build in 09m 59s on Fri, 6 Mar, 04:18 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1043

  4. TYPO3com voted on patch set 4 V +1 03/06/20, 16:26 Completed build in 10m 01s on Fri, 6 Mar, 04:26 PM Test Summary: 72070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1044

  5. Andreas Kienast rebased onto patch set 5 03/06/20, 16:33

  6. Andreas Kienast uploaded patch set 6 03/06/20, 16:33

  7. Andreas Kienast uploaded patch set 7 03/06/20, 16:33

  8. TYPO3com voted on patch set 5 V +1 03/06/20, 16:45 Completed build in 11m 35s on Fri, 6 Mar, 04:45 PM Test Summary: 72070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1046

  9. TYPO3com voted on patch set 6 V -1 03/06/20, 16:48 Completed build in 15m 02s on Fri, 6 Mar, 04:48 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1047

  10. TYPO3com voted on patch set 7 V -1 03/06/20, 16:51 Completed build in 15m 23s on Fri, 6 Mar, 04:51 PM Test Summary: 1 of 72556 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1048

  11. TYPO3com voted on patch set 7 V +1 03/06/20, 16:53 Completed build in 33m 26s on Fri, 6 Mar, 04:53 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1048

  12. Susi Moog updated the commit message in patch set 8 03/06/20, 16:53

  13. TYPO3com voted on patch set 8 V +1 03/06/20, 17:04 Completed build in 10m 37s on Fri, 6 Mar, 05:04 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1049

  14. Susi Moog voted on patch set 8 V +1 CR +1 03/07/20, 09:38

  15. Benni Mack commented on patch set 8 03/07/20, 10:59

    hmm, the UC setting is bound to the user, whereas the modal confirmation would be bound to the browser (so this could be put into LocalStorage instead?)
  16. Benni Mack updated the commit message in patch set 9 03/07/20, 14:02

  17. TYPO3com voted on patch set 9 V +1 03/07/20, 14:13 Completed build in 11m 00s on Sat, 7 Mar, 02:13 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1082

  18. Frank Nägler commented on patch set 9 CR -1 03/13/20, 20:39

    > Patch Set 8: > > hmm, the UC setting is bound to the user, whereas the modal confirmation would be bound to the browser (so this could be put into LocalStorage instead?) totally right, I will update the patch
  19. Frank Nägler uploaded patch set 10 03/13/20, 20:46

  20. TYPO3com voted on patch set 10 V -1 03/13/20, 21:18 Completed build in 19m 33s on Fri, 13 Mar, 09:18 PM Test Summary: 1 of 72685 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1336

  21. TYPO3com voted on patch set 10 V +1 03/13/20, 21:29 Completed build in 50m 06s on Fri, 13 Mar, 09:29 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1336

  22. Susi Moog voted on patch set 10 V +1 CR +1 03/15/20, 10:29

  23. Benni Mack voted on patch set 10 CR +2 03/19/20, 11:56

  24. Andreas Kienast voted on patch set 10 V +2 CR +2 03/20/20, 06:25

  25. Andreas Kienast merged patch set 11 03/20/20, 06:25