Review 9.5 Merged

63572[BUGFIX] Do not assign tab items if their content is empty

Daniel Goerz CR +2 V +2 Easy +16 −12 updated 03/06/20, 15:33

Commit message

In a TabsContainer, if all the fields of a tab are hidden to the editor
(by disabling them in PageTS), the tab would still become assigned in
the 'items' fluid variable. The empty, but invisible, tab would then
still be considered for determining the active tab in the view. If the
first tab was disabled in this way, the editor would see no active tab
at all.
To prevent this from happening, the tab elements are now never assigned,
if their content is completely empty.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Daniel Goerz commented on patch set 1 03/06/20, 15:01

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/06/20, 15:15 Completed build in 13m 38s on Fri, 6 Mar, 03:15 PM Test Summary: 74451 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-162

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 03/06/20, 15:33

  4. Daniel Goerz merged patch set 2 03/06/20, 15:33