Review 9.5 Merged

63574[BUGFIX] Fix handling of type "comment" in TypoScript Constant Editor

Benni Mack CR +2 V +2 Easy +5 −5 updated 03/06/20, 19:17

Commit message

According to the documentation, the boolean checkbox for type "comment"
should behave in the following way:
- checked= “”
- not-checked = “#”

The handling of this behaviour was faulty in the TypoScript Constant
Editor. This means, every time the constants were saved without changing
the "comment" checkbox, its value was reversed.
Further information:
https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/UsingSetting/TheConstantEditor.html

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 03/06/20, 18:33

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/06/20, 18:44 Completed build in 11m 54s on Fri, 6 Mar, 06:44 PM Test Summary: 74451 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-165

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/06/20, 18:58

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/06/20, 19:17

  5. Benni Mack merged patch set 2 03/06/20, 19:17