Review 9.5 Merged

63582[BUGFIX] Fix ActionMenuItemViewHelper select-attribute

Benni Mack CR +2 V +2 Easy +26 −7 updated 03/08/20, 08:08

Commit message

This commit fixes the setting of the select-attribute for menu items,
that have a different arguments-array given to them, but the same
controller => action combination as other menu items.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 69

  1. Benni Mack commented on patch set 1 03/07/20, 20:22

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemViewHelper.php
  2. TYPO3com voted on patch set 1 V -1 03/07/20, 20:23 Completed build in 23s on Sat, 7 Mar, 08:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-179

  3. Benni Mack commented on patch set 2 03/07/20, 20:23

    Published edit on patch set 1.
  4. Benni Mack commented on patch set 2 03/07/20, 20:23

    This change is ready for review.
  5. Georg Ringer voted on patch set 2 CR +1 03/07/20, 20:26

  6. TYPO3com voted on patch set 2 V -1 03/07/20, 20:35 Completed build in 11m 41s on Sat, 7 Mar, 08:35 PM Test Summary: 74088 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-180

  7. TYPO3com voted on patch set 2 V +1 03/08/20, 07:59 Completed build in 11h 47m 57s on Sun, 8 Mar, 07:59 AM Test Summary: 74451 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-180

  8. Benni Mack voted on patch set 2 V +2 CR +2 03/08/20, 08:08

  9. Benni Mack merged patch set 3 03/08/20, 08:08