Review 9.5 Merged

63586[BUGFIX] setSingletonInstance should respect XCLASS registrations

Andreas Kienast CR +2 V +2 Normal +65 −1 updated 03/08/20, 14:41

Commit message

GeneralUtility::makeInstance() stores singleton instances in their
overridden class names, however, when using setSingletonInstance
(which is used in TSFE) this is not connected, making a setSingletonInstance
break with another makeInstance call afterwards - returning a new,
non XCLASSED object.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 45

  1. Andreas Kienast commented on patch set 1 03/08/20, 14:23

    Cherry Picked from branch master.
  2. Oliver Klee voted on patch set 1 CR +1 03/08/20, 14:33

  3. TYPO3com voted on patch set 1 V +1 03/08/20, 14:36 Completed build in 12m 59s on Sun, 8 Mar, 02:36 PM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-189

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 03/08/20, 14:41

  5. Andreas Kienast merged patch set 2 03/08/20, 14:41