Review 9.5 Merged

63588[BUGFIX] Make default folder structure aware of 'web-dir' option

Georg Ringer CR +2 V +2 Hard +278 −157 updated 03/31/20, 07:49

Commit message

When having e.g. a composer-based installation in TYPO3 Core,
the install tool still generates the "wrong" folder structure in TYPO3.

When having e.g. "public" as subfolder where everything will
be installed, then the DefaultFactory should actually create
a /var/ folder (incl. /var/labels) and not keep the existing folder
structure (e.g. typo3temp/l10n).

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Georg Ringer commented on patch set 1 03/08/20, 20:43

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/08/20, 20:58 Completed build in 13m 05s on Sun, 8 Mar, 08:58 PM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-192

  3. Georg Ringer voted on patch set 1 V +2 CR +2 03/08/20, 21:05

  4. Georg Ringer merged patch set 2 03/08/20, 21:05

  5. Benni Mack wrote 03/31/20, 07:49

    Created a revert of this change as I493588d3c4c56d2b2e32b51c4c69d496dab4de33