Review main Merged

63593[BUGFIX] Force argument additionalConfig of MediaViewHelper as array

Georg Ringer CR +2 V +2 Easy +1 −1 updated 03/13/20, 19:56

Commit message

Make a type cast for the argument additionalConfig as it might be that
it is set as null.
Even though the original cause might be in fluid standalone, it is easy to
fix it in the meantime in our code base.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Eßl +1
    • Benni Mack +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Georg Ringer uploaded patch set 1 03/06/20, 21:27

  2. Georg Ringer commented on patch set 1 03/06/20, 21:27

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/06/20, 21:37 Completed build in 10m 17s on Fri, 6 Mar, 09:37 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1063

  4. Benni Mack voted on patch set 1 CR +1 03/07/20, 20:09

  5. Benni Mack updated the commit message in patch set 2 03/08/20, 21:23

  6. Benni Mack voted on patch set 2 CR +1 03/08/20, 21:23

  7. Oli Bartsch voted on patch set 2 CR +1 03/08/20, 21:31

  8. TYPO3com voted on patch set 2 V +1 03/08/20, 21:34 Completed build in 11m 12s on Sun, 8 Mar, 09:34 PM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1148

  9. Christian Eßl voted on patch set 2 CR +1 03/10/20, 20:10

  10. Benni Mack voted on patch set 2 V +1 03/11/20, 09:46

  11. Oli Bartsch voted on patch set 2 V +1 03/11/20, 18:04

  12. Oliver Klee voted on patch set 2 CR +1 03/12/20, 10:39

  13. Frank Nägler voted on patch set 2 CR +1 03/13/20, 19:51

  14. Frank Nägler voted on patch set 2 V +2 CR +2 03/13/20, 19:56

  15. Frank Nägler merged patch set 3 03/13/20, 19:56