Review main Merged

63595[BUGFIX] Fetch correct uid for ###REC_FIELD and group fields

Georg Ringer CR +2 V +2 Easy +4 −2 updated 03/19/20, 15:47

Commit message

If a field is used in `foreign_table_where` configuration which
points to a field using `group` as type, the uid needs to be fetched
differently from the processed row.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Georg Ringer uploaded patch set 1 03/07/20, 00:40

  2. Georg Ringer commented on patch set 1 03/07/20, 00:40

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 03/07/20, 00:52 Completed build in 12m 06s on Sat, 7 Mar, 12:52 AM Test Summary: 12 of 72577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1067

  4. Stefan Froemken commented on patch set 1 03/12/20, 23:46

    Reviewed and tested. I will add my +1, when Bamboo is happy with UnitTests
  5. Georg Ringer uploaded patch set 2 03/13/20, 06:56

  6. TYPO3com voted on patch set 2 V +1 03/13/20, 07:13 Completed build in 16m 25s on Fri, 13 Mar, 07:13 AM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1312

  7. Stefan Froemken commented on patch set 2 03/13/20, 08:46

    AbstractItemProvider.php:1107 Unresolved

    ?? should be possible.

    AbstractItemProvider.php:1107

    Is this still a valid possibility?
  8. Susi Moog voted on patch set 2 CR +1 03/15/20, 10:33

  9. Susi Moog voted on patch set 2 V +1 03/19/20, 13:55

  10. Georg Ringer commented on patch set 2 03/19/20, 14:26

    AbstractItemProvider.php:1107 Reply Unresolved

    TBH I don't know all edgecases
  11. Benni Mack commented on patch set 3 03/19/20, 15:07

    Published edit on patch set 2.
  12. Benni Mack voted on patch set 3 V +1 CR +1 03/19/20, 15:07

  13. TYPO3com voted on patch set 3 V +1 03/19/20, 15:21 Completed build in 13m 47s on Thu, 19 Mar, 03:21 PM Test Summary: 72108 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1454

  14. Susi Moog voted on patch set 3 V +2 CR +2 03/19/20, 15:47

  15. Susi Moog merged patch set 4 03/19/20, 15:47