Review main Merged

6360[BUGFIX] Fix baseurl handling of IE with RTE htmlArea in FE and realurl

Christoph Niewerth CR +2 V +2 Easy +11 −1 updated 06/03/13, 20:49

Commit message

Problem: IE does not support document.baseURI and document.URL is
incorrect when using realurl.
Solution: Get first base tag and extract href as base for iframe
document.

Review

  • Code review CR +2
    • Stanislas Rolland +2
  • Verified V +2
    • Stanislas Rolland +2

Issues 1

Files 1

Review log 11

  1. Susi Moog commented on patch set 2 03/16/12, 23:52

    Looks good to me, but someone else must approve
  2. Stanislas Rolland uploaded patch set 4 03/16/12, 23:52

  3. Stanislas Rolland commented on patch set 4 V 0 03/16/12, 23:52

    by team member; Looks good to me, approved
  4. Stefan Neufeind commented on patch set 3 03/16/12, 23:52

    Looks good to me, but someone else must approve fine by reading
    Resolves -> Fixes (it's a bugfix)
    and 4.8 meanwhile
  5. Oliver Hader uploaded patch set 3 03/16/12, 23:52

  6. Oliver Hader commented on patch set 3 03/16/12, 23:52

    Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Susanne Moog <typo3@susannemoog.de>
  7. Christoph Niewerth uploaded patch set 2 03/16/12, 23:52

  8. Mr. Jenkins commented on patch set 1 03/16/12, 23:52

  9. Mr. Jenkins commented on patch set 2 03/16/12, 23:52

  10. Mr. Jenkins commented on patch set 3 03/16/12, 23:52

  11. Stanislas Rolland merged patch set 4 03/16/12, 23:52