Review main Merged

63603[BUGFIX] Use parent page ID as PID for suggest fields

Susi Moog CR +2 V +2 Easy +1 −1 updated 03/08/20, 19:59

Commit message

TCA select fields have the capabilities for replacing ###CURRENT_PID###
with the parent page ID of the current record. This should always be
<table>.pid. In case of pages the wrong ID was used.

This was now changed to always use the parent page ID indepentent of
the current record. In case there is no parent page row, 0 is given.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Susi Moog uploaded patch set 1 03/07/20, 15:10

  2. Susi Moog commented on patch set 1 03/07/20, 15:10

    Tested with - pages (new and existing, on pid 0 and not) - tt_content (menu elements, new and existing) - flexforms with select / autosuggest
  3. TYPO3com voted on patch set 1 V -1 03/07/20, 15:20 Completed build in 10m 31s on Sat, 7 Mar, 03:20 PM Test Summary: 61564 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1083

  4. TYPO3com voted on patch set 1 V +1 03/07/20, 15:34 Completed build in 34m 29s on Sat, 7 Mar, 03:34 PM Test Summary: 72091 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1083

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 03/07/20, 15:46

  6. Georg Ringer voted on patch set 1 V +1 CR +1 03/07/20, 18:13

  7. Benni Mack voted on patch set 1 V +2 CR +2 03/08/20, 19:59

  8. Benni Mack merged patch set 2 03/08/20, 19:59