Review main Merged

63605[BUGFIX] Do not overwrite default thread count for Argon PasswordHashing

Susi Moog CR +2 V +2 Easy +4 −2 updated 03/22/20, 19:04

Commit message

There are systems and library combinations that do not allow the usage
of more than one thread to generate passwords. To ensure maximum
compatibility, the number of threads is reset to its default state.

If raising the number makes sense for performance reasons on systems
that support it, the setting can still be overwritten by setting
`$GLOBALS['TYPO3_CONF_VARS']['BE']['passwordHashing']['options']['threads']`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • Alexander Schnitzler +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1114

  1. Susi Moog uploaded patch set 1 03/07/20, 15:31

  2. TYPO3com voted on patch set 1 V -1 03/07/20, 15:42 Completed build in 10m 34s on Sat, 7 Mar, 03:42 PM Test Summary: 6 of 72577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1086

  3. Susi Moog uploaded patch set 2 03/07/20, 16:50

  4. TYPO3com voted on patch set 2 V -1 03/07/20, 17:00 Completed build in 10m 13s on Sat, 7 Mar, 05:00 PM Test Summary: 71680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1088

  5. TYPO3com voted on patch set 2 V +1 03/08/20, 06:13 Completed build in 13h 32m 52s on Sun, 8 Mar, 06:13 AM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1088

  6. Benni Mack commented on patch set 2 03/08/20, 07:54

    AbstractArgon2PasswordHash.php:30

    funny that the second comment contradicts the first one - maybe that's a good thing like this.
  7. Susi Moog commented on patch set 2 03/08/20, 10:06

    AbstractArgon2PasswordHash.php:30 Reply Unresolved

    they don't contradict each other. we are still raising memory and time, just not threads.
  8. Andreas Kienast voted on patch set 2 CR +1 03/09/20, 07:08

  9. Georg Ringer voted on patch set 2 CR +1 03/09/20, 07:33

  10. Daniel Goerz voted on patch set 2 CR +1 03/09/20, 08:25

  11. Benni Mack voted on patch set 2 V +1 CR +2 03/17/20, 20:10

  12. Alexander Schnitzler voted on patch set 2 V +1 CR +1 03/22/20, 08:34

  13. Benni Mack voted on patch set 2 V +2 03/22/20, 19:04

  14. Benni Mack merged patch set 3 03/22/20, 19:04