Review main Merged

63609[BUGFIX] Make default folder structure aware of 'web-dir' option

Benni Mack CR +2 V +2 Hard +278 −157 updated 03/08/20, 20:01

Commit message

When having e.g. a composer-based installation in TYPO3 Core,
the install tool still generates the "wrong" folder structure in TYPO3.

When having e.g. "public" as subfolder where everything will
be installed, then the DefaultFactory should actually create
a /var/ folder (incl. /var/labels) and not keep the existing folder
structure (e.g. typo3temp/l10n).

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Benni Mack uploaded patch set 1 03/07/20, 19:31

  2. TYPO3com voted on patch set 1 V +1 03/07/20, 19:41 Completed build in 10m 01s on Sat, 7 Mar, 07:41 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1093

  3. Benni Mack uploaded patch set 2 03/07/20, 19:52

  4. Georg Ringer voted on patch set 2 CR +1 03/07/20, 19:57

  5. Georg Ringer voted on patch set 2 V +1 03/07/20, 19:59

  6. TYPO3com voted on patch set 2 V +1 03/07/20, 20:03 Completed build in 10m 25s on Sat, 7 Mar, 08:03 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1096

  7. Benni Mack commented on patch set 3 03/08/20, 09:56

    Published edit on patch set 2.
  8. Susi Moog commented on patch set 3 V +1 CR +1 03/08/20, 10:05

    Tested on ddev and locally on IIS
  9. TYPO3com voted on patch set 3 V +1 03/08/20, 10:08 Completed build in 11m 41s on Sun, 8 Mar, 10:08 AM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1114

  10. Georg Ringer voted on patch set 3 V +2 CR +2 03/08/20, 20:01

  11. Georg Ringer merged patch set 4 03/08/20, 20:01