63610[BUGFIX] Skip empty static routes
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Daniel Goerz +1
- Benni Mack +1
-
Verified V +2 Done
- Susi Moog +2
- Daniel Goerz +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2130
Show 45 earlier messages
-
Georg Ringer uploaded patch set 1 03/07/20, 19:41
-
Georg Ringer commented on patch set 1 03/07/20, 19:42
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 03/07/20, 19:51 Completed build in 10m 19s on Sat, 7 Mar, 07:51 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1094
-
Benni Mack commented on patch set 2 03/07/20, 20:18
Published edit on patch set 1. -
Benni Mack voted on patch set 2 V +1 CR +1 03/07/20, 20:18
-
TYPO3com voted on patch set 2 V +1 03/07/20, 20:30 Completed build in 12m 08s on Sat, 7 Mar, 08:30 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1099
-
Andreas Kienast commented on patch set 2 V -1 03/08/20, 14:40
This fix doesn't cover all cases. If `route` in yaml is an empty string, everything is fine. If my route target is undefined, I still get the exception as described in the ticket. -
Georg Ringer uploaded patch set 3 03/08/20, 21:18
-
TYPO3com voted on patch set 3 V +1 03/08/20, 21:30 Completed build in 11m 45s on Sun, 8 Mar, 09:30 PM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1147
-
Andreas Kienast voted on patch set 3 V +1 CR +1 03/10/20, 07:14
-
Christian Eßl voted on patch set 3 V +1 CR +1 03/10/20, 07:27
-
Oli Bartsch commented on patch set 3 V -1 03/10/20, 07:44
I followed the "steps to reproduce" from the forge ticket and ended up with this configuration: routes: - route: '' type: uri This still breaks the frontend for me as the check only considers $route to be NULL. We should change it to something like `empty($route)`. -
Benni Mack uploaded patch set 4 03/20/20, 21:11
-
Benni Mack commented on patch set 4 CR -1 03/20/20, 21:11
added some basic tests -
Benni Mack commented on patch set 4 03/20/20, 21:12
still needs some work (writing the tests) -
TYPO3com voted on patch set 4 V -1 03/20/20, 21:27 Completed build in 15m 50s on Fri, 20 Mar, 09:27 PM Test Summary: 72129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1526
-
Benni Mack uploaded patch set 5 03/23/20, 09:33
-
Benni Mack voted on patch set 5 V +1 CR +1 03/23/20, 09:34
-
Georg Ringer voted on patch set 5 V +1 CR +1 03/23/20, 09:44
-
TYPO3com voted on patch set 5 V -1 03/23/20, 09:51 Completed build in 17m 11s on Mon, 23 Mar, 09:51 AM Test Summary: 72237 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1598
-
TYPO3com commented on patch set 5 03/23/20, 11:08 Completed build in 1h 51m 26s on Mon, 23 Mar, 11:08 AM Test Summary: 72237 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1598
-
TYPO3com commented on patch set 5 03/23/20, 11:11 Completed build in 3h 28m 35s on Mon, 23 Mar, 11:11 AM Test Summary: 72237 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1598
-
Benni Mack rebased onto patch set 6 03/23/20, 12:50
-
TYPO3com voted on patch set 6 V -1 03/23/20, 13:02 Completed build in 11m 31s on Mon, 23 Mar, 01:02 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1614
-
Benni Mack uploaded patch set 7 03/23/20, 13:17
-
TYPO3com voted on patch set 7 V +1 03/23/20, 13:29 Completed build in 11m 49s on Mon, 23 Mar, 01:29 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1617
-
Benni Mack voted on patch set 7 V +1 CR +1 03/23/20, 14:29
-
Daniel Goerz voted on patch set 7 V +1 CR +1 03/23/20, 16:01
-
Susi Moog voted on patch set 7 V +2 CR +2 03/23/20, 16:02
-
Susi Moog merged patch set 8 03/23/20, 16:02