63611[BUGFIX] Convert SVG files if fileExtension is explicitly set
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Hader +1
-
Verified V +2 Done
- Daniel Goerz +2
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1522
-
Benni Mack uploaded patch set 1 03/07/20, 20:06
-
Georg Ringer commented on patch set 1 03/07/20, 20:12
-
Benni Mack commented on patch set 1 03/07/20, 20:15
LocalCropScaleMaskHelper.php:105ReplyIt#s not the file, it's what you enter in your TypoScript or Fluid argument. However, we have multiple areas where we would need to streamline this, just because an integrator would write ".fileExtension=SVG" - sorry, but that wouldn't cut it. -
TYPO3com voted on patch set 1 V +1 03/07/20, 20:20 Completed build in 13m 28s on Sat, 7 Mar, 08:20 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1098
-
Oliver Hader voted on patch set 1 CR +1 03/10/20, 20:15
-
Georg Ringer commented on patch set 1 CR -1 03/10/20, 23:41
this doesn't work out that way. PoC ---- <f:image width="39" src="typo3/sysext/about/Resources/Public/Icons/module-about.svg" fileExtension="png" /> ---- For me this only works if I use this instead: --- ($task->getConfiguration()['fileExtension'] ?? 'svg') === 'svg' --- because with !== the fileExtension provided by the VH is png and this needs to be compared with svg And another problem is that if I don't provide a width the processing is not used and the svg is shown again. I know this might be out of scope for that and we have multiple issues where people would like to force a processed image but in this case, having a different target file type then the provided we really need that.LocalCropScaleMaskHelper.php:105ReplyAck -
Benni Mack commented on patch set 2 06/05/20, 06:00
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V -1 06/05/20, 06:11 Completed build in 11m 36s on Fri, 5 Jun, 06:11 AM Test Summary: 72829 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3850
-
TYPO3com voted on patch set 2 V +1 06/05/20, 06:16 Completed build in 27m 51s on Fri, 5 Jun, 06:16 AM Test Summary: 72830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3850
-
Tomas Norre Mikkelsen voted on patch set 2 CR +1 06/05/20, 08:15
-
Benni Mack updated the commit message in patch set 3 06/05/20, 09:32
-
TYPO3com voted on patch set 3 V -1 06/05/20, 09:44 Completed build in 12m 29s on Fri, 5 Jun, 09:44 AM Test Summary: 71521 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3853
-
TYPO3com voted on patch set 3 V +1 06/05/20, 12:22 Completed build in 3h 02m 25s on Fri, 5 Jun, 12:22 PM Test Summary: 72830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3853
-
Andreas Kienast voted on patch set 3 CR +1 06/05/20, 12:27
-
Daniel Goerz voted on patch set 3 V +1 CR +1 06/29/20, 16:32
-
Oliver Hader commented on patch set 3 CR -1 06/29/20, 18:00
On it (want to test something) -
Oliver Hader rebased onto patch set 4 06/29/20, 18:04
-
Oliver Hader voted on patch set 4 V +1 CR +1 06/29/20, 18:08
-
Daniel Goerz voted on patch set 4 V +2 CR +2 06/29/20, 18:10
-
TYPO3com voted on patch set 4 V -1 06/29/20, 18:20 Completed build in 16m 10s on Mon, 29 Jun, 06:20 PM Test Summary: 72227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4019
-
TYPO3com voted on patch set 4 V +1 06/29/20, 18:29 Completed build in 41m 30s on Mon, 29 Jun, 06:29 PM Test Summary: 72866 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4019
-
Daniel Goerz merged patch set 5 06/29/20, 18:31
LocalCropScaleMaskHelper.php:105