Review main Merged

63612[BUGFIX] Prioritize iconIdentifier over default icon for extbase modules

Georg Ringer CR +2 V +2 Easy +4 −0 updated 03/08/20, 07:51

Commit message

If ExtensionUtility::registerModule is called with a module
configuration only containing an icon identifier the default icon of
extbase is unset.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Georg Ringer uploaded patch set 1 03/07/20, 21:41

  2. Georg Ringer commented on patch set 1 03/07/20, 21:42

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/07/20, 21:51 Completed build in 10m 21s on Sat, 7 Mar, 09:51 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1106

  4. Susi Moog voted on patch set 1 CR +1 03/08/20, 06:07

  5. Susi Moog voted on patch set 1 V +1 03/08/20, 06:07

  6. Benni Mack voted on patch set 1 V +2 CR +2 03/08/20, 07:50

  7. Benni Mack merged patch set 2 03/08/20, 07:51