Review main Abandoned

63613[BUGFIX] Use correct icon & label for restoring deleted record in workspace

Georg Ringer CR 0 V 0 Normal +86 −2 updated 08/28/20, 13:56

Commit message

If a record which has been deleted in a workspace should be restored,
the icon and label in the context menu must match the restore action.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1419

  1. Georg Ringer uploaded patch set 1 03/07/20, 22:09

  2. Georg Ringer commented on patch set 1 03/07/20, 22:09

    This change is ready for review.
  3. Georg Ringer commented on patch set 1 CR -2 03/07/20, 22:10

    the triggered modal is still wrong. I propose to use a different callback action and use the correct modal, just as in #89599
  4. TYPO3com voted on patch set 1 V +1 03/07/20, 22:18 Completed build in 09m 23s on Sat, 7 Mar, 10:18 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1107

  5. Georg Ringer voted on patch set 1 CR 0 03/08/20, 07:29

  6. Andreas Kienast uploaded patch set 2 03/08/20, 07:47

  7. Andreas Kienast uploaded patch set 3 03/08/20, 07:49

  8. TYPO3com voted on patch set 2 V +1 03/08/20, 07:59 Completed build in 11m 30s on Sun, 8 Mar, 07:59 AM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1109

  9. TYPO3com voted on patch set 3 V +1 03/08/20, 08:10 Completed build in 15m 28s on Sun, 8 Mar, 08:10 AM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1111

  10. Susi Moog commented on patch set 3 V -1 03/15/20, 10:53

    The fix is incomplete as restoring the record removes it via ajax from the list module - same as delete would do (and does not trigger a page tree reload).
  11. Benni Mack updated the commit message in patch set 4 05/25/20, 18:44

  12. TYPO3com voted on patch set 4 V -1 05/25/20, 18:50 Completed build in 01m 01s on Mon, 25 May, 06:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3536

  13. Christian Kuhn uploaded patch set 5 08/11/20, 10:51

  14. Christian Kuhn commented on patch set 5 CR -1 08/11/20, 10:56

    Rebased for now. This is mostly for the click menu on records in list module. * The action itself does not work, the command should be delete=1, not undelete=1 (easy to change, compare with the undelete button in list module). Effectively, the existing delete placeholder record will be set to deleted=1 in db. * Probably, the same change should be done for page records (PageProvider)? -1 for now. I'm also still trying to understand further details in the delete/revert/restore area ...
  15. TYPO3com voted on patch set 5 V +1 08/11/20, 11:02 Completed build in 11m 02s on Tue, 11 Aug, 11:02 AM Test Summary: 72989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4567

  16. Christian Kuhn commented on patch set 5 08/11/20, 11:10

    * The popup content is not identical to the popup rendered im using the delete button in list module.
  17. Christian Kuhn commented on patch set 5 08/11/20, 11:17

    > Patch Set 3: Verified-1 > > The fix is incomplete as restoring the record removes it via ajax from the list module - same as delete would do (and does not trigger a page tree reload). The list module ajax call is quite broken anyway: it does not understand if inline-children are deleted together with an inline parent, too. In workspace with the restore functionality, this is worse, imho. I'd say, this area should be topic for other patches and should not be mixed into this patch.
  18. Christian Kuhn commented on patch set 5 08/28/20, 13:51

  19. Andreas Kienast abandoned the change 08/28/20, 13:56