Review main Merged

63616[BUGFIX] Respect editPanel.onlyCurrentPid = 1

Benni Mack CR +2 V +2 Easy +11 −6 updated 03/16/20, 19:28

Commit message

When accessing the editPanel, the option "onlyCurrentPid" allows to also
check the permissions of the editable record to verify if the user
is allowed to edit it.

When checking for CONTENT_EDIT permissions, the "onlyCurrentPid" is also
evaluated now, having "mayEdit" set to false by default, before evaluating
the condition further.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Benni Mack uploaded patch set 1 03/08/20, 10:15

  2. TYPO3com voted on patch set 1 V +1 03/08/20, 10:26 Completed build in 10m 57s on Sun, 8 Mar, 10:26 AM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1116

  3. Susi Moog voted on patch set 1 CR +1 03/08/20, 10:49

  4. Georg Ringer commented on patch set 1 03/09/20, 20:56

    FrontendBackendUserAuthentication.php:144 Unresolved

    we could check $this-isadmin first to avoid that call
  5. Benni Mack uploaded patch set 2 03/14/20, 12:09

  6. TYPO3com voted on patch set 2 V +1 03/14/20, 12:20 Completed build in 10m 46s on Sat, 14 Mar, 12:20 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1342

  7. Susi Moog voted on patch set 2 CR +1 03/15/20, 10:19

  8. Daniel Siepmann voted on patch set 2 V +1 03/16/20, 16:41

  9. Benni Mack voted on patch set 2 V +2 CR +2 03/16/20, 19:28

  10. Benni Mack merged patch set 3 03/16/20, 19:28