63617[TASK] Check symbolic link creation before auto updating
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Georg Ringer +1
- David Bruchmann +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2024
-
Susi Moog uploaded patch set 1 03/08/20, 10:40
-
TYPO3com voted on patch set 1 V -1 03/08/20, 10:41 Completed build in 22s on Sun, 8 Mar, 10:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1117
-
Susi Moog commented on patch set 2 03/08/20, 10:50
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 03/08/20, 11:07 Completed build in 14m 49s on Sun, 8 Mar, 11:07 AM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1119
-
David Bruchmann commented on patch set 2 03/08/20, 13:02
Raising a message like in the patch is absolutely enough, even I proposed more in the forge-issue. Nevertheless I'd propose to keep the line "unlink($file);" above the new code. So if with the new code is going something wrong on the server only one of test-file and test-symlink stays there and the situation will be easier to analyze even without the message. -
Susi Moog commented on patch set 3 03/09/20, 06:34
Published edit on patch set 2. -
Susi Moog commented on patch set 3 03/09/20, 06:35
> Patch Set 2: > > Raising a message like in the patch is absolutely enough, even I proposed more in the forge-issue. Nevertheless I'd propose to keep the line "unlink($file);" above the new code. So if with the new code is going something wrong on the server only one of test-file and test-symlink stays there and the situation will be easier to analyze even without the message. Yes, I know you proposed more, however this way, we can do it as a bug fix - anything more would only be possible for version 11 - so I decided the message is better than nothing :) I moved the unlink of the file up again - however I cannot move it above all of the new code as the test file is used to test the symlink. -
TYPO3com voted on patch set 3 V +1 03/09/20, 06:44 Completed build in 09m 48s on Mon, 9 Mar, 06:44 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1156
-
David Bruchmann commented on patch set 3 03/09/20, 06:52
> Patch Set 3: > > > Patch Set 2: > > > > Raising a message like in the patch is absolutely enough, even I proposed more in the forge-issue. Nevertheless I'd propose to keep the line "unlink($file);" above the new code. So if with the new code is going something wrong on the server only one of test-file and test-symlink stays there and the situation will be easier to analyze even without the message. > > Yes, I know you proposed more, however this way, we can do it as a bug fix - anything more would only be possible for version 11 - so I decided the message is better than nothing :) > > I moved the unlink of the file up again - however I cannot move it above all of the new code as the test file is used to test the symlink. I see, that's reasonable. In general it's ok like that I think. About the symlinks I don't know how they are always handled. The best would be letting composer do that job as it considers windows too. I have windows in mind where junction or mklink has to be used (composer is using junction as it never requires admin-access). So question is, if the symlink in your code works on windows too. -
Andreas Kienast commented on patch set 3 03/09/20, 07:05
We may use symlink(), PHP docs don't mention anything about UAC or alike for this one. -
Andreas Kienast commented on patch set 3 CR +1 03/09/20, 07:05
Forget my comment, I didn't have enough coffee yet -
David Bruchmann commented on patch set 3 03/09/20, 07:09
> I see, that's reasonable. In general it's ok like that I think. Sorry, I wrote bs :-) It's not ok like that, because the link never works if you remove the file. So either use a file which you know does exist but is not temporary for testing only, or move the line down again. -
Susi Moog commented on patch set 3 03/09/20, 07:13
Windows is irrelevant here, because: // No core update on windows if (Environment::isWindows()) { $success = false; $this->messages->enqueue(new FlashMessage( '', 'Automatic TYPO3 CMS core update not possible: Update not supported on Windows OS', FlashMessage::ERROR )); } -
David Bruchmann commented on patch set 3 03/09/20, 07:14
> Patch Set 3: > > We may use symlink(), PHP docs don't mention anything about UAC or alike for this one. Yes, another solution would concern some other code of TYPO3 too and be an own issue. So leave the function symlink() here first. -
David Bruchmann commented on patch set 3 03/09/20, 07:16
> // No core update on windows There we have the other issue I mention in the comment to Andreas ;-) Ok, then lets ignore my comment from before here. -
Susi Moog commented on patch set 4 03/09/20, 07:18
Published edit on patch set 3. -
Andreas Kienast voted on patch set 4 CR +1 03/09/20, 07:29
-
David Bruchmann commented on patch set 4 CR +1 03/09/20, 07:31
Thanks, after visual code-review I think that should work. Just as note I mention to related issues: 1) symlinks independent of OS. 2) localized feedback- and error-messages. -
TYPO3com voted on patch set 4 V +1 03/09/20, 07:33 Completed build in 13m 57s on Mon, 9 Mar, 07:33 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1158
-
Daniel Goerz voted on patch set 4 CR +1 03/09/20, 08:22
-
Benni Mack voted on patch set 4 V +1 CR +1 03/10/20, 11:49
-
Georg Ringer voted on patch set 4 V +1 CR +1 03/10/20, 11:49
-
Benni Mack voted on patch set 4 V +2 CR +2 03/10/20, 11:54
-
Benni Mack merged patch set 5 03/10/20, 11:54