Review main Merged

63618[BUGFIX] setSingletonInstance should respect XCLASS registrations

Benni Mack CR +2 V +2 Normal +65 −1 updated 03/08/20, 14:23

Commit message

GeneralUtility::makeInstance() stores singleton instances in their
overridden class names, however, when using setSingletonInstance
(which is used in TSFE) this is not connected, making a setSingletonInstance
break with another makeInstance call afterwards - returning a new,
non XCLASSED object.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 911

  1. Benni Mack uploaded patch set 1 03/08/20, 10:46

  2. Susi Moog voted on patch set 1 CR +1 03/08/20, 10:50

  3. Susi Moog voted on patch set 1 V +1 03/08/20, 10:53

  4. Benni Mack updated the commit message in patch set 2 03/08/20, 10:53

  5. TYPO3com voted on patch set 1 V +1 03/08/20, 11:01 Completed build in 14m 31s on Sun, 8 Mar, 11:01 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1118

  6. TYPO3com voted on patch set 2 V +1 03/08/20, 11:14 Completed build in 16m 48s on Sun, 8 Mar, 11:14 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1120

  7. Georg Ringer voted on patch set 2 V +1 CR +1 03/08/20, 11:34

  8. Oliver Klee voted on patch set 2 CR +1 03/08/20, 13:09

  9. Oli Bartsch voted on patch set 2 CR +1 03/08/20, 13:16

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 03/08/20, 14:23

  11. Andreas Kienast merged patch set 3 03/08/20, 14:23