Review main Merged

63619[BUGFIX] Respect clearCache_pageGrandParent for non-page records

Benni Mack CR +2 V +2 Easy +27 −8 updated 03/15/20, 07:34

Commit message

The setting TCEMAIN.clearCache_pageGrandParent clears the cache for
the parent parent page when editing the page properties of a page.
This now also flushes the cache for the parent page when editing page contents
of a page.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. Benni Mack uploaded patch set 1 03/08/20, 11:10

  2. TYPO3com voted on patch set 1 V -1 03/08/20, 11:22 Completed build in 11m 35s on Sun, 8 Mar, 11:22 AM Test Summary: 72091 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1122

  3. Georg Ringer commented on patch set 1 03/08/20, 11:32

    DataHandler.php:8026 Unresolved

    at leat new code should use proper variable names, thx
  4. TYPO3com voted on patch set 1 V +1 03/08/20, 21:09 Completed build in 10h 10m 20s on Sun, 8 Mar, 09:09 PM Test Summary: 72092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1122

  5. Benni Mack uploaded patch set 2 03/14/20, 19:04

  6. TYPO3com voted on patch set 2 V +1 03/14/20, 19:17 Completed build in 13m 27s on Sat, 14 Mar, 07:17 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1351

  7. Georg Ringer voted on patch set 2 V +1 CR +1 03/14/20, 19:33

  8. Susi Moog voted on patch set 2 CR +1 03/15/20, 06:26

  9. Susi Moog voted on patch set 2 V +2 CR +2 03/15/20, 07:34

  10. Susi Moog merged patch set 3 03/15/20, 07:34