Review main Merged

63620[BUGFIX] Keep priority of SQL operators in DatabaseRecordList

Susi Moog CR +2 V +2 Easy +2 −2 updated 03/09/20, 07:07

Commit message

DatabaseRecordList adds an additionalWhereClause with an `OR` which
may be extended by a hook. Usually, the hook is used to add additional
clauses. As the `OR` part is not wrapped in braces, this may result in
wrong priorities in the resulting query.

As there might be pre-existing work-arounds handling the situation,
the fix is done only on master.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Susi Moog uploaded patch set 1 03/08/20, 11:53

  2. TYPO3com voted on patch set 1 V -1 03/08/20, 12:04 Completed build in 10m 53s on Sun, 8 Mar, 12:04 PM Test Summary: 61873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1123

  3. TYPO3com voted on patch set 1 V +1 03/08/20, 14:25 Completed build in 2h 42m 12s on Sun, 8 Mar, 02:25 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1123

  4. Andreas Kienast voted on patch set 1 CR +1 03/08/20, 14:28

  5. Andreas Kienast voted on patch set 1 V +1 03/09/20, 07:06

  6. Georg Ringer voted on patch set 1 V +2 CR +2 03/09/20, 07:07

  7. Georg Ringer merged patch set 2 03/09/20, 07:07