Review main Merged

63621[BUGFIX] Bind onChange alert to field again

Andreas Kienast CR +2 V +2 Normal +48 −28 updated 03/08/20, 16:06

Commit message

The change of #88665 aimed to centralize the onchange behavior for all
FormEngine fields. The result of this change is that this didn't work
for all field types. Due to the fact the FormEngine rendering is rather
cluttered (e.g. sometimes there are hidden fields that hold the actual
value) and it's not possible to bind a global event delegation to such
fields right now, this patch now uses the onchange handling again which
was tried to be replaced.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 03/08/20, 14:14

  2. Andreas Kienast uploaded patch set 2 03/08/20, 14:17

  3. TYPO3com voted on patch set 1 V -1 03/08/20, 14:25 Completed build in 11m 12s on Sun, 8 Mar, 02:25 PM Test Summary: 71798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1127

  4. TYPO3com voted on patch set 2 V +1 03/08/20, 14:29 Completed build in 12m 01s on Sun, 8 Mar, 02:29 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1128

  5. Susi Moog voted on patch set 2 CR +1 03/08/20, 15:45

  6. Susi Moog commented on patch set 2 V +1 03/08/20, 15:53

    tested with styleguide extension with and without flexforms
  7. Andreas Kienast voted on patch set 2 V +2 CR +2 03/08/20, 16:06

  8. Andreas Kienast merged patch set 3 03/08/20, 16:06