63629[BUGFIX] Only set BE user cookie when logged in
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Markus Klein +1
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Markus Klein +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1114
-
Benni Mack uploaded patch set 1 03/08/20, 21:04
-
TYPO3com voted on patch set 1 V +1 03/08/20, 21:15 Completed build in 11m 37s on Sun, 8 Mar, 09:15 PM Test Summary: 72097 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1145
-
Philipp Gampe commented on patch set 1 03/10/20, 23:22
Thanks for taking care, lgtm -
Benni Mack updated the commit message in patch set 2 05/25/20, 18:43
-
TYPO3com voted on patch set 2 V -1 05/25/20, 19:41 Completed build in 52m 31s on Mon, 25 May, 07:41 PM Test Summary: 1 of 74292 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3534
-
Oliver Hader commented on patch set 2 08/17/20, 17:45
BackendUserAuthenticator.php:80This still sends direct HTTP headers - it would be "nice" when cookie handling is extracted from BE_USER object and applied to the response object instead -
Markus Klein commented on patch set 2 08/17/20, 18:40
BackendUserAuthenticator.php:80Reply UnresolvedThis looks like a bigger refactoring to me. I would rather try to do that in a dedicated patch. So we can backport this one and do the refactoring in master only? -
Markus Klein uploaded patch set 3 08/17/20, 19:05
-
TYPO3com voted on patch set 3 V +1 08/17/20, 19:17 Completed build in 11m 18s on Mon, 17 Aug, 07:17 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4743
-
Markus Klein voted on patch set 3 V +1 CR +1 08/17/20, 19:19
-
Christian Kuhn commented on patch set 3 V +1 CR +1 08/18/20, 18:13
not 100% sure on 10.4 ... maybe merge to master and delay for 10.4, just to see if we missed something? -
Anja Leichsenring voted on patch set 3 V +2 CR +2 08/18/20, 19:40
-
Anja Leichsenring merged patch set 4 08/18/20, 19:40
-
Christian Kuhn commented on patch set 4 09/03/20, 19:56
this has been backported with https://review.typo3.org/c/Packages/TYPO3.CMS/+/65372 ... seems we somehow managed to munge the change-id for the backport ...