Review main Merged

63632[BUGFIX] Calculate correct list of pages for SuggestWizardDefaultReceiver

Georg Ringer CR +2 V +2 Normal +20 −41 updated 03/09/20, 10:20

Commit message

The suggest receiver can be configured to search only in provided page
ids and a provided depth. Fix the calculation of those pages by using
`PageTreeView`.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1419

  1. Georg Ringer uploaded patch set 1 03/08/20, 23:08

  2. Georg Ringer commented on patch set 1 03/08/20, 23:09

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 03/08/20, 23:09 Completed build in 24s on Sun, 8 Mar, 11:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1152

  4. Georg Ringer uploaded patch set 2 03/09/20, 07:16

  5. TYPO3com voted on patch set 2 V +1 03/09/20, 07:29 Completed build in 12m 51s on Mon, 9 Mar, 07:29 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1157

  6. Daniel Goerz commented on patch set 2 V -1 03/09/20, 09:43

    This is not working as expected, will push a new PS
  7. Oli Bartsch commented on patch set 2 V -1 03/09/20, 09:47

    SuggestWizardDefaultReceiver.php:111 Unresolved

    Could we please use `(int)($config['pidDepth'] ?? 0)` here to avoid possible PHP notices?

    SuggestWizardDefaultReceiver.php:113 Unresolved

    This operand does not work as the implicit keys from getAvailablePageIds() are always the same and won't be added to the array. Fixing this by setting the pid also as key would prevent this but another approach is to collect the arrays and merge them together after the foreach. Will provide a new patch set for this.
  8. Daniel Goerz uploaded patch set 3 03/09/20, 09:52

  9. Daniel Goerz commented on patch set 4 03/09/20, 09:55

    Published edit on patch set 3.
  10. Georg Ringer voted on patch set 4 V +1 CR +1 03/09/20, 09:57

  11. Daniel Goerz commented on patch set 4 CR -1 03/09/20, 09:59

    We are going to move the array_merge out of the loop
  12. Oli Bartsch uploaded patch set 5 03/09/20, 10:02

  13. Oli Bartsch voted on patch set 5 V +1 CR +1 03/09/20, 10:03

  14. TYPO3com voted on patch set 3 V +1 03/09/20, 10:03 Completed build in 10m 56s on Mon, 9 Mar, 10:03 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1168

  15. TYPO3com voted on patch set 4 V +1 03/09/20, 10:07 Completed build in 11m 42s on Mon, 9 Mar, 10:07 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1169

  16. Georg Ringer voted on patch set 5 V +1 CR +1 03/09/20, 10:08

  17. TYPO3com voted on patch set 5 V +1 03/09/20, 10:13 Completed build in 10m 22s on Mon, 9 Mar, 10:13 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1170

  18. Daniel Goerz voted on patch set 5 V +2 CR +2 03/09/20, 10:20

  19. Daniel Goerz merged patch set 6 03/09/20, 10:20