Review main Merged

63635[BUGFIX] Allow external images for FluidEmail image ViewHelpers

Georg Ringer CR +2 V +2 Normal +70 −50 updated 05/01/20, 22:35

Commit message

To overcome external images via FluidEmail and apply the similar
behaviour as in LoginController, the <f:image> and <f:uri.image>
ViewHelpers do not process external images but just return them,
allowing logins again with custom login images and "sendNotificationEmail"
settings turned on.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Jonas Eberle +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 3452

Show 1827 earlier messages
  1. Georg Ringer uploaded patch set 1 03/09/20, 07:54

  2. Georg Ringer commented on patch set 1 03/09/20, 07:55

    @Benni or should we fetch the image first and building the URL afterwards ...
  3. TYPO3com voted on patch set 1 V +1 03/09/20, 08:06 Completed build in 11m 40s on Mon, 9 Mar, 08:06 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1159

  4. Andreas Kienast commented on patch set 1 03/09/20, 08:23

    Other idea: can we preprocess the image path and simply use <img> instead?
  5. Andreas Kienast commented on patch set 1 03/09/20, 08:24

    FluidEmail.php:119

    preg_match('/^https?:/', $systemConfiguration['backend']['loginLogo'])
  6. Benni Mack commented on patch set 1 03/09/20, 10:51

    FluidEmail.php:119 Reply Unresolved

    See loginController - we do have a lot of these checks in BackendController and LoginController, which we should centralize I'd say. And then a Fluid VH could check this properly as well?
  7. Georg Ringer uploaded patch set 2 03/09/20, 13:51

  8. TYPO3com voted on patch set 2 V -1 03/09/20, 13:51 Completed build in 22s on Mon, 9 Mar, 01:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1186

  9. Georg Ringer uploaded patch set 3 03/09/20, 13:52

  10. TYPO3com voted on patch set 3 V +1 03/09/20, 14:02 Completed build in 10m 01s on Mon, 9 Mar, 02:02 PM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1187

  11. Oli Bartsch commented on patch set 3 CR -1 03/09/20, 15:02

    FluidEmail.php:116 Unresolved

    Could we please use the `ExtensionConfiguration` here.
  12. Georg Ringer uploaded patch set 4 03/10/20, 04:56

  13. TYPO3com voted on patch set 4 V +1 03/10/20, 05:15 Completed build in 19m 20s on Tue, 10 Mar, 05:15 AM Test Summary: 72159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1203

  14. Oli Bartsch commented on patch set 4 V -1 03/10/20, 08:33

    We are working on it.
  15. Oli Bartsch uploaded patch set 5 03/10/20, 08:49

  16. Oli Bartsch updated the commit message in patch set 6 03/10/20, 08:52

  17. TYPO3com voted on patch set 5 V +1 03/10/20, 09:00 Completed build in 10m 48s on Tue, 10 Mar, 09:00 AM Test Summary: 72159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1207

  18. TYPO3com voted on patch set 6 V -1 03/10/20, 09:04 Completed build in 11m 53s on Tue, 10 Mar, 09:04 AM Test Summary: 72149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1208

  19. TYPO3com voted on patch set 6 V +1 03/10/20, 09:20 Completed build in 12m 43s on Tue, 10 Mar, 09:20 AM Test Summary: 72159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1209

  20. Benni Mack commented on patch set 6 03/10/20, 11:53

    ExtensionConfiguration.php:122

    what kind of "drive-by" fix is this?

    HttpUtility.php:217

    should we typehint this to "string $filename"?
  21. Georg Ringer commented on patch set 6 03/10/20, 12:05

    ExtensionConfiguration.php:122 Reply Unresolved

    Encapsulate access to globals to this class

    HttpUtility.php:217 Reply Unresolved

    Good idea
  22. Georg Ringer uploaded patch set 7 03/10/20, 12:40

  23. TYPO3com voted on patch set 7 V +1 03/10/20, 12:51 Completed build in 10m 37s on Tue, 10 Mar, 12:51 PM Test Summary: 72189 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1216

  24. Andreas Kienast commented on patch set 7 V -1 03/11/20, 20:27

    EXT: syntax doesn't work, it misses the domain in front.
  25. Georg Ringer commented on patch set 7 CR -1 03/12/20, 10:21

    the image is now missing the domain :/
  26. Georg Ringer uploaded patch set 8 03/17/20, 12:03

  27. TYPO3com voted on patch set 8 V -1 03/17/20, 12:15 Completed build in 11m 18s on Tue, 17 Mar, 12:15 PM Test Summary: 3 of 72544 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1394

  1. Georg Ringer rebased onto patch set 9 03/17/20, 19:59

  2. TYPO3com voted on patch set 9 V -1 03/17/20, 20:16 Completed build in 16m 33s on Tue, 17 Mar, 08:16 PM Test Summary: 3 of 72544 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1403

  3. Georg Ringer rebased onto patch set 10 04/07/20, 03:28

  4. TYPO3com voted on patch set 10 V -1 04/07/20, 03:55 Completed build in 20m 18s on Tue, 7 Apr, 03:55 AM Test Summary: 3 of 73871 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2246

  5. Georg Ringer uploaded patch set 11 04/07/20, 04:10

  6. TYPO3com voted on patch set 11 V -1 04/07/20, 05:09 Completed build in 53m 09s on Tue, 7 Apr, 05:09 AM Test Summary: 73387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2247

  7. TYPO3com commented on patch set 11 04/07/20, 06:10 Completed build in 13m 03s on Tue, 7 Apr, 06:10 AM Test Summary: 72864 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2255

  8. TYPO3com voted on patch set 11 V +1 04/07/20, 09:15 Completed build in 14m 48s on Tue, 7 Apr, 09:15 AM Test Summary: 73385 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2261

  9. Anja Leichsenring voted on patch set 11 V +1 CR +1 04/12/20, 11:42

  10. Benni Mack uploaded patch set 12 04/12/20, 12:18

  11. Guido Schmechel commented on patch set 12 04/12/20, 12:20

    Allow
  12. TYPO3com voted on patch set 12 V +1 04/12/20, 12:29 Completed build in 10m 52s on Sun, 12 Apr, 12:29 PM Test Summary: 73395 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2396

  13. Björn Jacob updated the commit message in patch set 13 04/12/20, 15:08

  14. Björn Jacob commented on patch set 13 04/12/20, 15:08

    I hope it's okay that I've changed the commit msg :/
  15. Björn Jacob commented on patch set 13 04/12/20, 15:08

    Reply

    Done
  16. TYPO3com voted on patch set 13 V +1 04/12/20, 15:19 Completed build in 11m 46s on Sun, 12 Apr, 03:19 PM Test Summary: 73397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2399

  17. Jonas Eberle rebased onto patch set 14 04/12/20, 18:29

  18. Jonas Eberle uploaded patch set 15 04/12/20, 18:30

  19. Jonas Eberle commented on patch set 15 V +1 CR +1 04/12/20, 18:32

    Very nice! Added a note about external URLs being passed through for the ViewHelper reference.
  20. TYPO3com voted on patch set 14 V +1 04/12/20, 18:41 Completed build in 11m 24s on Sun, 12 Apr, 06:41 PM Test Summary: 73397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2400

  21. TYPO3com voted on patch set 15 V +1 04/12/20, 18:46 Completed build in 15m 19s on Sun, 12 Apr, 06:46 PM Test Summary: 73397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2401

  22. Georg Ringer voted on patch set 15 V +2 CR +2 04/12/20, 18:53

  23. Georg Ringer merged patch set 16 04/12/20, 18:53

  24. Josef Glatz voted on patch set 16 V +1 CR +1 04/12/20, 19:02

  25. Helmut Hummel wrote 05/01/20, 22:35

    Created a revert of this change as Ib97b7b19b03c9819dc187d5ca2a92a506d54dc91