Review main Abandoned

63637[BUGFIX] Use site in BackendConfigurationManager to fetch correct root page

Georg Ringer CR 0 V 0 Easy +9 −0 updated 10/08/21, 08:08

Commit message

page

Instead of just getting the first page marked as root page, the actual
site information can be used.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 03/09/20, 08:52

  2. Georg Ringer commented on patch set 1 03/09/20, 08:54

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 03/09/20, 09:02 Completed build in 10m 10s on Mon, 9 Mar, 09:02 AM Test Summary: 618 of 72583 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1164

  4. Georg Ringer uploaded patch set 2 03/09/20, 09:12

  5. TYPO3com voted on patch set 2 V +1 03/09/20, 09:26 Completed build in 13m 47s on Mon, 9 Mar, 09:26 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1166

  6. Benni Mack commented on patch set 2 CR +1 03/09/20, 10:50

    This is actually helping a bit, but won't work for e.g. backend modules that do not have a page ID as anchor. But that's life (= a conceptual issue which we need to solve in a way to have backend modules be able to give a page or site as context - don't know how to fix this properly yet). So this change is OK IMHO
  7. Christian Eßl voted on patch set 2 CR +1 03/10/20, 20:05

  8. Stefan Froemken commented on patch set 2 V -1 03/12/20, 09:02

    Your solution does not solve the problem mentioned in Forge. A Site will only be created, if you have clicked on a Page in PageTree. If you edit a record, the id-Parameter is not in Request anymore and a NullSite will be created. So your code returns 0 and StoragePid will be retrieved by first found page in PageTree again. In case of Backend Modules your code will only help, if you just have clicked on a page in PageTree. If you click somewhere on a link within the BE module the id-Parameter is away again. It's up to the Dev to keep this id in each request. IMO it is wrong to retrieve the TS in BE with Extbase's ConfigurationManager in itemsProcFunc. He rather should use the TemplateService directly and set ID by himself instead of any magic.
  9. Stefan Froemken commented on patch set 2 03/12/20, 21:18

    I found another problem: The body of your new site condition will never be reached. As a Site will only be created, if an id parameter is given in request. But the condition before your site condition will check against id-Parameter already. So, if an id is given, your new code will never be reached.
  10. Alexander Schnitzler wrote 04/12/20, 10:56

    Topic set to extbase
  11. Benni Mack commented on patch set 2 10/08/21, 08:06

    what's the status here? If nothing happens, I will abandon the change for the time being.
  12. Georg Ringer abandoned the change 10/08/21, 08:08