Review main Merged

63639[TASK] Deprecate Extbase model FileMount

Georg Ringer CR +2 V +2 Normal +51 −1 updated 03/10/20, 09:06

Commit message

The Extbase model `FileMount` has never been used and there is also no
need to have a model for every table. To streamline the codebase, the
class has been marked as deprecated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1319

  1. Georg Ringer uploaded patch set 1 03/09/20, 11:41

  2. Georg Ringer commented on patch set 1 03/09/20, 11:41

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 03/09/20, 11:41 Completed build in 22s on Mon, 9 Mar, 11:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1173

  4. Christian Eßl commented on patch set 1 03/09/20, 11:44

    Deprecation-90686-DeprecateModelFileMount.rst:14 Unresolved

    * really
  5. Georg Ringer uploaded patch set 2 03/09/20, 11:44

  6. TYPO3com voted on patch set 2 V -1 03/09/20, 11:55 Completed build in 10m 25s on Mon, 9 Mar, 11:55 AM Test Summary: 42 of 72583 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1174

  7. Oli Bartsch uploaded patch set 3 03/09/20, 12:38

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 03/09/20, 12:43

  9. TYPO3com voted on patch set 3 V -1 03/09/20, 12:49 Completed build in 10m 29s on Mon, 9 Mar, 12:49 PM Test Summary: 42 of 72274 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1179

  10. Georg Ringer uploaded patch set 4 03/09/20, 13:10

  11. TYPO3com voted on patch set 4 V -1 03/09/20, 13:20 Completed build in 10m 33s on Mon, 9 Mar, 01:20 PM Test Summary: 72078 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1180

  12. Georg Ringer uploaded patch set 5 03/09/20, 13:26

  13. TYPO3com commented on patch set 4 03/09/20, 13:38 Completed build in 14m 05s on Mon, 9 Mar, 01:38 PM Test Summary: 72078 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1183

  14. TYPO3com voted on patch set 5 V +1 03/09/20, 13:45 Completed build in 15m 45s on Mon, 9 Mar, 01:45 PM Test Summary: 72078 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1185

  15. Oliver Klee voted on patch set 5 CR +1 03/09/20, 13:46

  16. Christian Eßl voted on patch set 5 V +1 CR +1 03/09/20, 13:47

  17. Oli Bartsch voted on patch set 5 V +1 CR +1 03/09/20, 14:00

  18. Benni Mack voted on patch set 5 V +2 CR +2 03/10/20, 09:06

  19. Benni Mack merged patch set 6 03/10/20, 09:06