Review main Merged

63640[BUGFIX] Resolve nested public path inside ext:install DefaultFactory

Jan Delius CR +2 V +2 Normal +79 −51 updated 03/10/20, 13:36

Commit message

This patch provides support for nested public paths in the TYPO3
installer. The DefaultFactory iterates backwards through the components
of the path to build a correct array.
To keep the source code as simple as possible, the substructure is
already built and passed to the function. Thus references in the code
can be avoided.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Rico Drexler +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 711

  1. Jan Delius uploaded patch set 1 03/09/20, 11:50

  2. Jan Delius rebased onto patch set 2 03/09/20, 11:57

  3. TYPO3com voted on patch set 1 V +1 03/09/20, 12:02 Completed build in 11m 04s on Mon, 9 Mar, 12:02 PM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1175

  4. TYPO3com voted on patch set 2 V -1 03/09/20, 12:08 Completed build in 10m 51s on Mon, 9 Mar, 12:08 PM Test Summary: 72098 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1177

  5. TYPO3com voted on patch set 2 V +1 03/09/20, 12:14 Completed build in 27m 40s on Mon, 9 Mar, 12:14 PM Test Summary: 72098 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1177

  6. TYPO3com commented on patch set 2 03/09/20, 12:38 Completed build in 10m 23s on Mon, 9 Mar, 12:38 PM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1178

  7. Rico Drexler voted on patch set 2 V +1 03/09/20, 14:33

  8. Benni Mack voted on patch set 2 CR +1 03/10/20, 11:49

  9. Georg Ringer voted on patch set 2 V +1 CR +1 03/10/20, 13:18

  10. Benni Mack voted on patch set 2 V +2 CR +2 03/10/20, 13:36

  11. Benni Mack merged patch set 3 03/10/20, 13:36