Review main Merged

63641[TASK] Deprecate FileCollection models

Georg Ringer CR +2 V +2 Normal +85 −0 updated 03/13/20, 20:31

Commit message

The classes have been marked as internal and never contained any logic.
Therefore and in order to streamline the codebase of Extbase,
the files will be removed with TYPO3 11.0.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 2126

Show 1 earlier messages
  1. Georg Ringer uploaded patch set 1 03/09/20, 13:23

  1. Georg Ringer commented on patch set 1 03/09/20, 13:23

    This change is ready for review.
  2. TYPO3com voted on patch set 1 V -1 03/09/20, 13:23 Completed build in 21s on Mon, 9 Mar, 01:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1181

  3. Georg Ringer uploaded patch set 2 03/09/20, 13:24

  4. Georg Ringer uploaded patch set 3 03/09/20, 13:25

  5. TYPO3com voted on patch set 2 V -1 03/09/20, 13:36 Completed build in 12m 18s on Mon, 9 Mar, 01:36 PM Test Summary: 71792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1182

  6. TYPO3com voted on patch set 3 V +1 03/09/20, 13:42 Completed build in 12m 55s on Mon, 9 Mar, 01:42 PM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1184

  7. Oliver Klee voted on patch set 3 CR +1 03/09/20, 13:45

  8. Christian Eßl voted on patch set 3 V +1 CR +1 03/09/20, 13:46

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 03/09/20, 14:03

  10. Oliver Hader commented on patch set 3 CR -1 03/09/20, 21:08

    What about `AbstractFileCollectionConverter` and derived implementations?
  11. Georg Ringer uploaded patch set 4 03/09/20, 21:23

  12. Oliver Hader voted on patch set 4 CR +1 03/09/20, 21:28

  13. TYPO3com voted on patch set 4 V +1 03/09/20, 21:35 Completed build in 11m 38s on Mon, 9 Mar, 09:35 PM Test Summary: 72159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1202

  14. Oliver Klee voted on patch set 4 CR +1 03/09/20, 22:34

  15. Christian Eßl voted on patch set 4 CR +1 03/10/20, 06:24

  16. Georg Ringer uploaded patch set 5 03/10/20, 09:27

  17. TYPO3com voted on patch set 5 V +1 03/10/20, 09:37 Completed build in 10m 16s on Tue, 10 Mar, 09:37 AM Test Summary: 72137 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1211

  18. Oliver Klee voted on patch set 5 CR +1 03/10/20, 09:45

  19. Alexander Schnitzler commented on patch set 5 03/10/20, 10:56

    AbstractFileCollection.php:27

    Introducing a constructor possibly breaks child classes. I would recommend triggering the deprecation above the class definition i.e. on file load.
  20. Stefan Froemken commented on patch set 5 03/12/20, 07:42

    AbstractFileCollection.php:27 Reply

    HOw it can break child classes? This constructor does not have any parameters, so no problem. If child classes have their own constructor, this constructor will not be called, so no triggered error, so no problem. If child classes have a constructor and they call this constructor, an error will be triggered, what was expected (only on DEV Systems), so no problem. So, where do you see breaking child classes?
  21. Frank Nägler voted on patch set 5 CR +1 03/13/20, 20:19

  22. Alexander Schnitzler commented on patch set 5 03/13/20, 20:24

    AbstractFileCollection.php:27 Reply

    Hi Stefan, you are absolutely right about that. I didn't think enough about it. But we could still think about triggering the deprecation on file load to cover all cases. But I don't have a strong opninion about this. So I am fine with both ways.
  23. Alexander Schnitzler voted on patch set 5 V +1 CR +1 03/13/20, 20:28

  24. Frank Nägler voted on patch set 5 V +2 CR +2 03/13/20, 20:30

  25. Frank Nägler merged patch set 6 03/13/20, 20:31