63644[TASK] Define SiteLanguage as composite child of SiteInterface
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- typo3/sysext/core/Classes/Site/Entity/NullSite.php+6 −4
- typo3/sysext/core/Classes/Site/Entity/Site.php+3 −2
- typo3/sysext/core/Classes/Site/Entity/SiteLanguage.php3+23 −1
- typo3/sysext/core/Documentation/Changelog/9.5.x/Important-90716-DefineSiteLanguageAsCompositeChildOfSiteInterface.rstnew+45 −0
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteTest.php+18 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ConstructorArgumentMatcher.php+12 −2
Review log 2536
Show 611 earlier messages
-
Oliver Hader uploaded patch set 1 03/09/20, 17:50
-
TYPO3com voted on patch set 1 V -1 03/09/20, 17:51 Completed build in 27s on Mon, 9 Mar, 05:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1189
-
Oliver Hader uploaded patch set 2 03/09/20, 17:54
-
TYPO3com voted on patch set 2 V -1 03/09/20, 18:09 Completed build in 14m 22s on Mon, 9 Mar, 06:09 PM Test Summary: 72121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1190
-
Oliver Hader uploaded patch set 3 03/09/20, 19:59
-
Oliver Hader uploaded patch set 4 03/09/20, 20:05
-
TYPO3com voted on patch set 3 V -1 03/09/20, 20:13 Completed build in 13m 59s on Mon, 9 Mar, 08:13 PM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1199
-
TYPO3com voted on patch set 4 V -1 03/09/20, 20:21 Completed build in 15m 37s on Mon, 9 Mar, 08:21 PM Test Summary: 71814 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1200
-
TYPO3com voted on patch set 4 V +1 03/09/20, 20:35 Completed build in 45m 49s on Mon, 9 Mar, 08:35 PM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1200
-
Oliver Hader marked it work in progress 03/09/20, 20:51
-
Oliver Hader uploaded patch set 5 03/10/20, 13:53
-
TYPO3com voted on patch set 5 V -1 03/10/20, 13:54 Completed build in 25s on Tue, 10 Mar, 01:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1220
-
Oliver Hader uploaded patch set 6 03/10/20, 20:00
-
TYPO3com voted on patch set 6 V -1 03/10/20, 20:00 Completed build in 10s on Tue, 10 Mar, 08:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1230
-
Oliver Hader uploaded patch set 7 03/10/20, 20:04
-
Oliver Hader commented on patch set 7 03/10/20, 20:05
This change is ready for review. -
TYPO3com voted on patch set 7 V +1 03/10/20, 20:19 Completed build in 14m 01s on Tue, 10 Mar, 08:19 PM Test Summary: 72177 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1231
-
Andreas Kienast voted on patch set 7 V +1 CR +1 03/10/20, 21:13
-
Oliver Hader voted on patch set 7 CR -1 03/10/20, 23:05
-
Oliver Hader uploaded patch set 8 03/10/20, 23:06
-
TYPO3com voted on patch set 8 V +1 03/10/20, 23:20 Completed build in 13m 40s on Tue, 10 Mar, 11:20 PM Test Summary: 72177 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1237
-
Oliver Hader voted on patch set 8 CR -1 03/11/20, 12:48
-
Oliver Hader uploaded patch set 9 03/11/20, 12:53
-
Oliver Hader commented on patch set 9 03/11/20, 12:54
Now it's complete from my POV, having extension scanner configuration & functionality in place as well... -
TYPO3com voted on patch set 9 V +1 03/11/20, 13:07 Completed build in 13m 06s on Wed, 11 Mar, 01:07 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1254
-
Oliver Hader uploaded patch set 10 03/11/20, 17:26
-
TYPO3com commented on patch set 10 03/11/20, 17:38 Completed build in 11m 59s on Wed, 11 Mar, 05:38 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1260
-
Helmut Hummel commented on patch set 10 03/12/20, 15:09
SiteLanguage.php:226I think we can be strict here and return SiteInterface can't we? All places in TYPO3 that use this new API make sure the site is actually set. -
Andreas Kienast commented on patch set 10 03/12/20, 15:31
SiteLanguage.php:226Reply$site is optional for now, see constructor arguments -
Helmut Hummel commented on patch set 10 V +1 CR +1 03/12/20, 15:32
I have this one applied on a 9.5 production system. Works well. -
Helmut Hummel commented on patch set 10 V 0 CR 0 03/12/20, 15:33
> Patch Set 10: Verified+1 Code-Review+1 > > I have this one applied on a 9.5 production system. Works well. Uhm, wrong patch, sorry -
Helmut Hummel commented on patch set 10 03/12/20, 15:36
I'd rather be careful with circular depedencies. See e.g. here: https://medium.com/@johann.pardanaud/about-circular-references-in-php-10f71f811e9 Most of the issues could be solved with WeakReference, but this requires a PHP extension or PHP 7.4 -
Oliver Hader commented on patch set 10 CR -1 03/12/20, 15:55
-
Oliver Hader commented on patch set 10 03/12/20, 16:20
SiteLanguage.php:226Reply UnresolvedThe reason for having it optional is to avoid breaking behavior for SiteLanguage that then would a new mandatory argument - basically in user-land scenarios outside the TYPO3 core... -
Oliver Hader commented on patch set 10 CR 0 03/12/20, 17:02
Changed https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585/15 - for the time being this change is not required anymore -
Oliver Hader abandoned the change 03/12/20, 17:03