Review main Merged

63645[TASK] Streamline SiteLanguage related tests to be based on Site

Oliver Hader CR +2 V +2 Hard +256 −73 updated 03/09/20, 19:55

Commit message

Tests making use of SiteLanguage are adjusted to have a valid parent
Site object. This way the implicit aggregate root approach of Site
is kept and hanging SiteLanguage instances are avoided.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 49

  1. Oliver Hader uploaded patch set 1 03/09/20, 17:58

  2. TYPO3com voted on patch set 1 V +1 03/09/20, 18:14 Completed build in 15m 15s on Mon, 9 Mar, 06:14 PM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1191

  3. Oliver Hader updated the commit message in patch set 2 03/09/20, 19:13

  4. TYPO3com voted on patch set 2 V -1 03/09/20, 19:15 Completed build in 02m 04s on Mon, 9 Mar, 07:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1196

  5. TYPO3com commented on patch set 2 03/09/20, 19:30 Completed build in 18m 37s on Mon, 9 Mar, 07:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1196

  6. TYPO3com commented on patch set 2 03/09/20, 19:34 Completed build in 39m 02s on Mon, 9 Mar, 07:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1196

  7. TYPO3com voted on patch set 2 V +1 03/09/20, 19:49 Completed build in 1h 15m 11s on Mon, 9 Mar, 07:49 PM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1196

  8. Oliver Hader voted on patch set 2 V +2 CR +2 03/09/20, 19:55

  9. Oliver Hader merged patch set 3 03/09/20, 19:55