Review 9.5 Merged

63648[TASK] Streamline SiteLanguage related tests to be based on Site

Oliver Hader CR +2 V +2 Normal +135 −44 updated 03/09/20, 19:56

Commit message

Tests making use of SiteLanguage are adjusted to have a valid parent
Site object. This way the implicit aggregate root approach of Site
is kept and hanging SiteLanguage instances are avoided.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 36

  1. Oliver Hader uploaded patch set 1 03/09/20, 19:27

  2. TYPO3com voted on patch set 1 V -1 03/09/20, 19:29 Completed build in 02m 04s on Mon, 9 Mar, 07:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-204

  3. TYPO3com commented on patch set 1 03/09/20, 19:33 Completed build in 08m 31s on Mon, 9 Mar, 07:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-204

  4. TYPO3com voted on patch set 1 V +1 03/09/20, 19:53 Completed build in 35m 16s on Mon, 9 Mar, 07:53 PM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-204

  5. Oliver Hader voted on patch set 1 V +2 CR +2 03/09/20, 19:56

  6. Oliver Hader merged patch set 2 03/09/20, 19:56