Review main Abandoned

63649[DOCS] Don't create a false impression of security for fileDenyPattern

Daniel Siepmann CR 0 V 0 Easy +1 −1 updated 03/16/20, 16:46

Commit message

Mention situations where the option might be ignored.
Also rephrase hint about further involved software like web server.
TYPO3 can't cover all environments with in depth instructions. Security
of web server should be mentioned, but handled by responsible persons.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1215

  1. Daniel Siepmann uploaded patch set 1 03/10/20, 07:23

  2. TYPO3com voted on patch set 1 V +1 03/10/20, 07:34 Completed build in 10m 53s on Tue, 10 Mar, 07:34 AM Test Summary: 72159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1206

  3. Björn Jacob commented on patch set 1 03/10/20, 07:38

    DefaultConfigurationDescription.yaml:361

    "whatever" feels a bit inappropriate here (like "slang"). Can we extend the list of actions which will be denied? Or at least replace "whatever" with "etc." or "and so on".

    DefaultConfigurationDescription.yaml:361

    The word is inconsistently written, sometimes lowercase and sometimes uppercase. Why do we capitalize it anyway?
  4. Daniel Siepmann uploaded patch set 2 03/10/20, 10:30

  5. Daniel Siepmann commented on patch set 2 03/10/20, 10:31

    DefaultConfigurationDescription.yaml:361 Reply

    Rephrased that part to create a list of known actions + etc.

    DefaultConfigurationDescription.yaml:361 Reply

    Used lowercase as already done in sentence before.
  6. TYPO3com voted on patch set 2 V +1 03/10/20, 10:41 Completed build in 10m 14s on Tue, 10 Mar, 10:41 AM Test Summary: 72138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1212

  7. Helmut Hummel commented on patch set 2 03/10/20, 11:32

    DefaultConfigurationDescription.yaml:361

    IIRC TYPO3 does not ignore this option any more for admins. So I tend to say that this part of the ticket is resolved and fileDenyPattern does not need further clarification. I'd say that any third party code allowing file upload but ignoring this pattern has security issues which need to be fixed (like with any other securty issue), thus it does not need to be mentioned here imho
  8. Daniel Siepmann uploaded patch set 3 03/10/20, 11:42

  9. Daniel Siepmann commented on patch set 3 03/10/20, 11:44

    DefaultConfigurationDescription.yaml:361 Reply Unresolved

    Thanks for the update. Can you tell me something about "cookieSecure" option? Do we need to clarify anything for this option?
  10. Benni Mack commented on patch set 3 03/10/20, 11:52

    Please merge directly + make it for 9.5 as well. Also: AFAIK this pattern is not ignored for TYPO3 administrators
  11. Oliver Hader commented on patch set 3 CR -1 03/10/20, 11:52

    DefaultConfigurationDescription.yaml:361

    Probably that's not correct - if it is ignore, please report findings to security@typo3.org
  12. TYPO3com voted on patch set 3 V +1 03/10/20, 11:53 Completed build in 10m 23s on Tue, 10 Mar, 11:53 AM Test Summary: 72138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1213

  13. Helmut Hummel commented on patch set 3 03/10/20, 12:44

    > Patch Set 3: Code-Review-1 > > (1 comment)

    DefaultConfigurationDescription.yaml:361 Reply Unresolved

  14. Daniel Siepmann uploaded patch set 4 03/16/20, 16:46

  15. Daniel Siepmann abandoned the change 03/16/20, 16:46

    No more changes necessary anymore