Review main Merged

63672[TASK] Make "N/A" translatable

Susi Moog CR +2 V +2 Easy +10 −7 updated 03/11/20, 09:07

Commit message

The string "N/A" was hardcoded in BackendUtility
and has now been made translatable.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Susi Moog uploaded patch set 1 03/10/20, 16:09

  2. TYPO3com voted on patch set 1 V +1 03/10/20, 16:23 Completed build in 13m 17s on Tue, 10 Mar, 04:22 PM Test Summary: 72165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1222

  3. Björn Jacob commented on patch set 1 03/10/20, 16:35

    BackendUtility.php:1745 Unresolved

    IMHO n/a does not mean "not available" but "not applicable". See https://dict.leo.org/englisch-deutsch/n%2Fa
  4. Susi Moog commented on patch set 1 03/10/20, 17:31

    > Patch Set 1: > > (1 comment) different sources ;) http://www.learnersdictionary.com/definition/NA gotta love abbreviations.
  5. Georg Ringer commented on patch set 1 CR -1 03/10/20, 17:33

    Resname must be same as id
  6. Susi Moog commented on patch set 2 03/10/20, 17:38

    Published edit on patch set 1.
  7. Björn Jacob commented on patch set 2 V +1 CR +1 03/10/20, 17:39

    Mkay, I can live with it :)
  8. TYPO3com voted on patch set 2 V -1 03/10/20, 17:50 Completed build in 12m 12s on Tue, 10 Mar, 05:50 PM Test Summary: 1 of 72646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1225

  9. TYPO3com voted on patch set 2 V +1 03/11/20, 07:23 Completed build in 13h 57m 33s on Wed, 11 Mar, 07:23 AM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1225

  10. Oli Bartsch voted on patch set 2 V +1 CR +1 03/11/20, 08:58

  11. Georg Ringer voted on patch set 2 V +2 CR +2 03/11/20, 09:07

  12. Georg Ringer merged patch set 3 03/11/20, 09:07