Review main Merged

63675[BUGFIX] Mark field as changed, when changing text in ckeditor source mode

Christian Eßl CR +2 V +2 Easy +9 −0 updated 03/13/20, 20:08

Commit message

Changing content in the 'source' mode textarea of ckeditor does not
automatically trigger a change event for its parent textarea. Because
of that, the field was never marked as "changed" in the FormEngine and
the user would then not receive a warning modal when closing the form
without saving first. This behaviour is now fixed.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Christian Eßl uploaded patch set 1 03/10/20, 19:28

  2. TYPO3com voted on patch set 1 V +1 03/10/20, 19:38 Completed build in 10m 14s on Tue, 10 Mar, 07:38 PM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1227

  3. Riccardo De Contardi commented on patch set 1 V +1 03/10/20, 22:24

    verified with latest master
  4. Georg Ringer commented on patch set 1 03/10/20, 23:27

    RichTextElement.php:243

    wanna remove those spaces?
  5. Christian Eßl commented on patch set 1 03/11/20, 14:47

    RichTextElement.php:243 Reply

    Ack
  6. Christian Eßl uploaded patch set 2 03/11/20, 14:49

  7. TYPO3com voted on patch set 2 V +1 03/11/20, 15:01 Completed build in 11m 45s on Wed, 11 Mar, 03:01 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1256

  8. Riccardo De Contardi commented on patch set 2 V +1 03/11/20, 20:47

    tested on latest master
  9. Georg Ringer voted on patch set 2 V +1 CR +1 03/12/20, 07:54

  10. Frank Nägler voted on patch set 2 CR +1 03/13/20, 20:04

  11. Frank Nägler voted on patch set 2 V +2 CR +2 03/13/20, 20:08

  12. Frank Nägler merged patch set 3 03/13/20, 20:08