63676[BUGFIX] Handle constructor arguments in extension scanner correctly
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/install/Classes/Controller/UpgradeController.php+13 −2
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/AbstractCoreMatcher.php+28 −21
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcher.phpnew+241 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/GeneratorClassesResolver.php+30 −4
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ConstructorArgumentMatcher.phpnew+38 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php+0 −6
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentRequiredMatcher.php+0 −8
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentUnusedMatcher.php+0 −7
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+0 −8
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ConstructorArgumentMatcherFixture.phpnew+43 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/Subject.phpnew+26 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcherTest.phpnew+105 −0
Review log 1014
-
Oliver Hader uploaded patch set 1 03/10/20, 19:46
-
TYPO3com voted on patch set 1 V -1 03/10/20, 19:46 Completed build in 24s on Tue, 10 Mar, 07:46 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1228
-
Oliver Hader uploaded patch set 2 03/10/20, 19:48
-
TYPO3com voted on patch set 2 V +1 03/10/20, 19:59 Completed build in 10m 52s on Tue, 10 Mar, 07:59 PM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1229
-
Andreas Kienast voted on patch set 2 CR +1 03/10/20, 21:10
-
Oliver Hader voted on patch set 2 CR -1 03/10/20, 21:52
-
Oliver Hader uploaded patch set 3 03/10/20, 23:04
-
TYPO3com voted on patch set 3 V -1 03/10/20, 23:05 Completed build in 23s on Tue, 10 Mar, 11:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1236
-
Oliver Hader uploaded patch set 4 03/10/20, 23:09
-
TYPO3com voted on patch set 4 V +1 03/10/20, 23:27 Completed build in 15m 03s on Tue, 10 Mar, 11:27 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1238
-
Andreas Kienast voted on patch set 4 V +1 CR +1 03/11/20, 09:14
-
Benni Mack voted on patch set 4 V +2 CR +2 03/11/20, 09:48
-
Georg Ringer voted on patch set 4 CR +1 03/11/20, 09:55
-
Oliver Hader merged patch set 5 03/11/20, 12:46