63678[TASK] Migrate TestTask to FluidEmail
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1218
-
Georg Ringer uploaded patch set 1 03/10/20, 22:47
-
TYPO3com voted on patch set 1 V -1 03/10/20, 22:47 Completed build in 23s on Tue, 10 Mar, 10:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1235
-
Georg Ringer uploaded patch set 2 03/10/20, 23:25
-
Georg Ringer commented on patch set 2 03/10/20, 23:26
This change is ready for review. -
TYPO3com voted on patch set 2 V -1 03/10/20, 23:36 Completed build in 10m 50s on Tue, 10 Mar, 11:36 PM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1239
-
Georg Ringer uploaded patch set 3 03/10/20, 23:44
-
TYPO3com voted on patch set 3 V -1 03/10/20, 23:56 Completed build in 12m 44s on Tue, 10 Mar, 11:56 PM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1240
-
Georg Ringer uploaded patch set 4 03/11/20, 00:01
-
TYPO3com voted on patch set 4 V -1 03/11/20, 00:12 Completed build in 10m 18s on Wed, 11 Mar, 12:12 AM Test Summary: 71862 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1241
-
Georg Ringer rebased onto patch set 5 03/11/20, 07:42
-
TYPO3com voted on patch set 5 V +1 03/11/20, 07:56 Completed build in 13m 17s on Wed, 11 Mar, 07:56 AM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1248
-
Markus Klein commented on patch set 5 03/17/20, 10:37
TestTask.php:61Unresolvedwhy no makeInstance? -
Oli Bartsch commented on patch set 5 V -1 03/17/20, 12:13
TestTask.php:46UnresolvedThis is never changed so we can simply return false at the end.TestTask.php:74Unresolved`maxLifetime: `TestTask.html:10UnresolvedThe timestamp is missing compared to the current emailTestTask.html:11UnresolvedThe timestamp is missing compared to the current email -
Oli Bartsch uploaded patch set 6 03/17/20, 12:16
-
Oli Bartsch voted on patch set 6 V +1 CR +1 03/17/20, 12:17
-
TYPO3com voted on patch set 6 V +1 03/17/20, 12:28 Completed build in 11m 07s on Tue, 17 Mar, 12:28 PM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1395
-
Benni Mack voted on patch set 6 V +2 CR +2 03/18/20, 07:59
-
Benni Mack merged patch set 7 03/18/20, 07:59