Review main Merged

63678[TASK] Migrate TestTask to FluidEmail

Georg Ringer CR +2 V +2 Normal +69 −25 updated 03/18/20, 07:59

Commit message

Use the FluidEmail service for sending the test task of EXT:scheduler.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1218

  1. Georg Ringer uploaded patch set 1 03/10/20, 22:47

  2. TYPO3com voted on patch set 1 V -1 03/10/20, 22:47 Completed build in 23s on Tue, 10 Mar, 10:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1235

  3. Georg Ringer uploaded patch set 2 03/10/20, 23:25

  4. Georg Ringer commented on patch set 2 03/10/20, 23:26

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V -1 03/10/20, 23:36 Completed build in 10m 50s on Tue, 10 Mar, 11:36 PM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1239

  6. Georg Ringer uploaded patch set 3 03/10/20, 23:44

  7. TYPO3com voted on patch set 3 V -1 03/10/20, 23:56 Completed build in 12m 44s on Tue, 10 Mar, 11:56 PM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1240

  8. Georg Ringer uploaded patch set 4 03/11/20, 00:01

  9. TYPO3com voted on patch set 4 V -1 03/11/20, 00:12 Completed build in 10m 18s on Wed, 11 Mar, 12:12 AM Test Summary: 71862 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1241

  10. Georg Ringer rebased onto patch set 5 03/11/20, 07:42

  11. TYPO3com voted on patch set 5 V +1 03/11/20, 07:56 Completed build in 13m 17s on Wed, 11 Mar, 07:56 AM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1248

  12. Markus Klein commented on patch set 5 03/17/20, 10:37

    TestTask.php:61 Unresolved

    why no makeInstance?
  13. Oli Bartsch commented on patch set 5 V -1 03/17/20, 12:13

    TestTask.php:46 Unresolved

    This is never changed so we can simply return false at the end.

    TestTask.php:74 Unresolved

    `maxLifetime: `

    TestTask.html:10 Unresolved

    The timestamp is missing compared to the current email

    TestTask.html:11 Unresolved

    The timestamp is missing compared to the current email
  14. Oli Bartsch uploaded patch set 6 03/17/20, 12:16

  15. Oli Bartsch voted on patch set 6 V +1 CR +1 03/17/20, 12:17

  16. TYPO3com voted on patch set 6 V +1 03/17/20, 12:28 Completed build in 11m 07s on Tue, 17 Mar, 12:28 PM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1395

  17. Benni Mack voted on patch set 6 V +2 CR +2 03/18/20, 07:59

  18. Benni Mack merged patch set 7 03/18/20, 07:59