Review main Merged

63680[TASK] Centralize CgiServer check in Environment API

Benni Mack CR +2 V +2 Normal +48 −33 updated 03/21/20, 18:48

Commit message

"GeneralUtility::isRunningOnCgiServerApi()" is now deprecated
in favor of "Environment::isRunningOnCgiServer()".

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Haupt +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1014

  1. Benni Mack uploaded patch set 1 03/11/20, 07:28

  2. Andreas Kienast commented on patch set 1 03/11/20, 07:40

    GeneralUtility.php:2637 Unresolved

    Environment::
  3. TYPO3com voted on patch set 1 V -1 03/11/20, 07:43 Completed build in 14m 02s on Wed, 11 Mar, 07:43 AM Test Summary: 17471 of 72571 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1246

  4. Benni Mack uploaded patch set 2 03/21/20, 07:46

  5. TYPO3com voted on patch set 2 V -1 03/21/20, 07:57 Completed build in 11m 41s on Sat, 21 Mar, 07:57 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1528

  6. Susi Moog commented on patch set 2 V +1 CR +1 03/21/20, 08:54

    Environment.php:320

    in case anybody is wondering: this method was just introduced, so we are still free to change the name.
  7. Benni Mack commented on patch set 2 CR -1 03/21/20, 09:08

    Environment.php:320 Reply

    aah, I think we should keep it as before (because we also backported the change introducing this method back into 9.5)
  8. TYPO3com voted on patch set 2 V +1 03/21/20, 09:15 Completed build in 1h 41m 27s on Sat, 21 Mar, 09:15 AM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1528

  9. Anja Leichsenring commented on patch set 2 CR -1 03/21/20, 09:34

    Environment.php:320 Reply Unresolved

  10. Benni Mack uploaded patch set 3 03/21/20, 12:50

  11. TYPO3com voted on patch set 3 V +1 03/21/20, 13:01 Completed build in 10m 55s on Sat, 21 Mar, 01:01 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1539

  12. Daniel Haupt voted on patch set 3 V +1 CR +1 03/21/20, 16:24

  13. Georg Ringer voted on patch set 3 V +2 CR +2 03/21/20, 18:48

  14. Georg Ringer merged patch set 4 03/21/20, 18:48