Review main Merged

63681[TASK] Show duplicated entrypoints in site module as warning

Georg Ringer CR +2 V +2 Normal +195 −1 updated 03/13/20, 19:44

Commit message

If an entrypoint URL is used more than once this will lead in errors and
a warning will be shown in the site module.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1728

Show 23 earlier messages
  1. Georg Ringer uploaded patch set 1 03/11/20, 07:40

  2. TYPO3com voted on patch set 1 V -1 03/11/20, 07:41 Completed build in 23s on Wed, 11 Mar, 07:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1247

  3. Georg Ringer uploaded patch set 2 03/11/20, 07:54

  1. TYPO3com voted on patch set 2 V +1 03/11/20, 08:14 Completed build in 19m 18s on Wed, 11 Mar, 08:14 AM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1249

  2. Oli Bartsch commented on patch set 2 03/11/20, 18:41

    SiteConfigurationController.php:124 Unresolved

    Possible null pointer here.

    Overview.html:12

    Could we please add a label for this.

    Overview.html:14 Unresolved

    As we have the information `count` should we not output it?
  3. Georg Ringer uploaded patch set 3 03/11/20, 20:36

  4. TYPO3com voted on patch set 3 V -1 03/11/20, 20:37 Completed build in 38s on Wed, 11 Mar, 08:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1264

  5. Georg Ringer uploaded patch set 4 1 comment 03/11/20, 22:41

  6. TYPO3com voted on patch set 4 V -1 03/11/20, 22:42 Completed build in 22s on Wed, 11 Mar, 10:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1270

  7. Georg Ringer commented on patch set 4 03/11/20, 22:42

    This change is ready for review.

    Overview.html:12 Reply Unresolved

    yes that will be added tomorrow, as well as tests
  8. Georg Ringer uploaded patch set 5 03/11/20, 22:42

  9. TYPO3com voted on patch set 5 V +1 03/11/20, 22:54 Completed build in 11m 55s on Wed, 11 Mar, 10:54 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1271

  10. Oli Bartsch uploaded patch set 6 03/12/20, 07:45

  11. Georg Ringer voted on patch set 6 V +1 CR +1 03/12/20, 07:47

  12. TYPO3com voted on patch set 6 V +1 03/12/20, 08:01 Completed build in 15m 51s on Thu, 12 Mar, 08:01 AM Test Summary: 72200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1277

  13. Oli Bartsch uploaded patch set 7 03/12/20, 08:50

  14. Oli Bartsch uploaded patch set 8 03/12/20, 08:59

  15. Oli Bartsch uploaded patch set 9 03/12/20, 09:01

  16. TYPO3com voted on patch set 7 V -1 03/12/20, 09:09 Completed build in 18m 07s on Thu, 12 Mar, 09:09 AM Test Summary: 6 of 72685 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1279

  17. TYPO3com voted on patch set 8 V -1 03/12/20, 09:16 Completed build in 16m 52s on Thu, 12 Mar, 09:16 AM Test Summary: 6 of 72685 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1280

  18. TYPO3com voted on patch set 9 V -1 03/12/20, 09:21 Completed build in 14m 55s on Thu, 12 Mar, 09:21 AM Test Summary: 6 of 72685 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1281

  19. Oli Bartsch uploaded patch set 10 03/12/20, 09:34

  20. TYPO3com voted on patch set 10 V -1 03/12/20, 09:45 Completed build in 11m 21s on Thu, 12 Mar, 09:45 AM Test Summary: 70161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1282

  21. TYPO3com voted on patch set 10 V +1 03/12/20, 13:07 Completed build in 14m 29s on Thu, 12 Mar, 01:07 PM Test Summary: 72199 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1287

  22. Georg Ringer voted on patch set 10 V +1 CR +1 03/12/20, 20:57

  23. Frank Nägler voted on patch set 10 CR +1 03/13/20, 19:41

  24. Frank Nägler voted on patch set 10 V +2 CR +2 03/13/20, 19:43

  25. Frank Nägler merged patch set 11 03/13/20, 19:44