Review main Merged

63682[TASK] Adjust php doc blocks for phpstan level 2 compatibility

Alexander Schnitzler CR +2 V +2 Normal +37 −30 updated 03/19/20, 12:32

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 24

Show 4 more files

Review log 1418

  1. Alexander Schnitzler uploaded patch set 1 03/11/20, 08:37

  2. Alexander Schnitzler wrote 03/11/20, 08:41

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V +1 03/11/20, 08:56 Completed build in 18m 56s on Wed, 11 Mar, 08:56 AM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1250

  4. Georg Ringer voted on patch set 1 CR +1 03/11/20, 08:57

  5. Oliver Klee voted on patch set 1 CR +1 03/11/20, 09:20

  6. Alexander Schnitzler uploaded patch set 2 03/15/20, 18:38

  7. TYPO3com voted on patch set 2 V -1 03/15/20, 18:49 Completed build in 11m 26s on Sun, 15 Mar, 06:49 PM Test Summary: 71948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1371

  8. TYPO3com voted on patch set 2 V +1 03/15/20, 19:09 Completed build in 42m 43s on Sun, 15 Mar, 07:09 PM Test Summary: 72270 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1371

  9. Oliver Klee voted on patch set 2 CR +1 03/15/20, 19:37

  10. Alexander Schnitzler commented on patch set 2 03/18/20, 17:39

    ping
  11. Georg Ringer commented on patch set 2 03/18/20, 17:46

    ExtendedTemplateService.php:459 Unresolved

    can you please change that as well
  12. Georg Ringer voted on patch set 2 V +1 CR +1 03/18/20, 17:47

  13. Georg Ringer commented on patch set 3 03/19/20, 12:15

    Published edit on patch set 2.
  14. Georg Ringer voted on patch set 3 V +1 CR +1 03/19/20, 12:15

  15. Oliver Klee voted on patch set 3 CR +1 03/19/20, 12:17

  16. TYPO3com voted on patch set 3 V +1 03/19/20, 12:28 Completed build in 12m 48s on Thu, 19 Mar, 12:28 PM Test Summary: 72107 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1443

  17. Benni Mack voted on patch set 3 V +2 CR +2 03/19/20, 12:32

  18. Benni Mack merged patch set 4 03/19/20, 12:32