63683[BUGFIX] Handle constructor arguments in extension scanner correctly
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
-
Verified V +2 Done
- Oliver Hader +2
- TYPO3com +1 CI
Issues 1
Files 11
- typo3/sysext/install/Classes/Controller/UpgradeController.php+13 −2
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/AbstractCoreMatcher.php+28 −21
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcher.phpnew+241 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/GeneratorClassesResolver.php+30 −4
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ConstructorArgumentMatcher.phpnew+26 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php+0 −6
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentRequiredMatcher.php+0 −7
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentUnusedMatcher.php+0 −6
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ConstructorArgumentMatcherFixture.phpnew+43 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/Subject.phpnew+26 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcherTest.phpnew+105 −0
Review log 34
-
Oliver Hader uploaded patch set 1 03/11/20, 12:46
-
TYPO3com voted on patch set 1 V +1 03/11/20, 12:59 Completed build in 12m 50s on Wed, 11 Mar, 12:59 PM Test Summary: 74544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-209
-
Oliver Hader voted on patch set 1 V +2 CR +2 03/11/20, 19:15
-
Oliver Hader merged patch set 2 03/11/20, 19:16