Review main Merged

63684[BUGFIX] Show value '0' in cells of table content element

Georg Ringer CR +2 V +2 Easy +2 −2 updated 03/12/20, 07:58

Commit message

Adjust the check of the value to make it also possible
to show the valid cell value '0' of content element table.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Markus Klein +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Stefan Froemken +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1721

  1. Georg Ringer uploaded patch set 1 03/11/20, 13:33

  2. Georg Ringer commented on patch set 1 03/11/20, 13:33

    This change is ready for review.
  3. Markus Klein commented on patch set 1 CR -1 03/11/20, 13:34

    Lets compare against empty string instead.
  4. TYPO3com voted on patch set 1 V +1 03/11/20, 13:44 Completed build in 11m 43s on Wed, 11 Mar, 01:44 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1255

  5. Georg Ringer commented on patch set 1 03/11/20, 13:47

    > Lets compare against empty string instead. We don't have such VH and I don't know which harm we do with just calling nl2br VH anyway?
  6. Markus Klein commented on patch set 1 03/11/20, 14:19

    > Patch Set 1: > > > Lets compare against empty string instead. > > We don't have such VH and I don't know which harm we do with just calling nl2br VH anyway? empty table cells might look strange on some browers ,therefore the nbsp. I consider a simple `condition="{cell} != ''"`
  7. Georg Ringer commented on patch set 1 03/11/20, 14:27

    Damn phpstorm didn't show the nbsp..
  8. Georg Ringer uploaded patch set 2 03/11/20, 20:22

  9. Andreas Kienast voted on patch set 2 V +1 CR +1 03/11/20, 20:33

  10. TYPO3com voted on patch set 2 V +1 03/11/20, 20:44 Completed build in 15m 25s on Wed, 11 Mar, 08:44 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1263

  11. Riccardo De Contardi commented on patch set 2 03/11/20, 20:52

    tested on latest master
  12. Riccardo De Contardi voted on patch set 2 V +1 03/11/20, 20:53

  13. Markus Klein voted on patch set 2 CR +1 03/11/20, 21:42

  14. Markus Klein updated the commit message in patch set 3 03/11/20, 21:42

  15. Markus Klein voted on patch set 3 CR +1 03/11/20, 21:42

  16. TYPO3com voted on patch set 3 V -1 03/11/20, 21:55 Completed build in 12m 17s on Wed, 11 Mar, 09:55 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1268

  17. TYPO3com voted on patch set 3 V +1 03/11/20, 22:19 Completed build in 11m 13s on Wed, 11 Mar, 10:19 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1269

  18. Oli Bartsch voted on patch set 3 V +1 CR +1 03/12/20, 07:16

  19. Stefan Froemken commented on patch set 3 V +1 CR +1 03/12/20, 07:30

    I have tested it with various values. Yeah, works.
  20. Andreas Kienast voted on patch set 3 V +2 CR +2 03/12/20, 07:57

  21. Andreas Kienast merged patch set 4 03/12/20, 07:58