63684[BUGFIX] Show value '0' in cells of table content element
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Markus Klein +1
- Stefan Froemken +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Stefan Froemken +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1721
-
Georg Ringer uploaded patch set 1 03/11/20, 13:33
-
Georg Ringer commented on patch set 1 03/11/20, 13:33
This change is ready for review. -
Markus Klein commented on patch set 1 CR -1 03/11/20, 13:34
Lets compare against empty string instead. -
TYPO3com voted on patch set 1 V +1 03/11/20, 13:44 Completed build in 11m 43s on Wed, 11 Mar, 01:44 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1255
-
Georg Ringer commented on patch set 1 03/11/20, 13:47
> Lets compare against empty string instead. We don't have such VH and I don't know which harm we do with just calling nl2br VH anyway? -
Markus Klein commented on patch set 1 03/11/20, 14:19
> Patch Set 1: > > > Lets compare against empty string instead. > > We don't have such VH and I don't know which harm we do with just calling nl2br VH anyway? empty table cells might look strange on some browers ,therefore the nbsp. I consider a simple `condition="{cell} != ''"` -
Georg Ringer commented on patch set 1 03/11/20, 14:27
Damn phpstorm didn't show the nbsp.. -
Georg Ringer uploaded patch set 2 03/11/20, 20:22
-
Andreas Kienast voted on patch set 2 V +1 CR +1 03/11/20, 20:33
-
TYPO3com voted on patch set 2 V +1 03/11/20, 20:44 Completed build in 15m 25s on Wed, 11 Mar, 08:44 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1263
-
Riccardo De Contardi commented on patch set 2 03/11/20, 20:52
tested on latest master -
Riccardo De Contardi voted on patch set 2 V +1 03/11/20, 20:53
-
Markus Klein voted on patch set 2 CR +1 03/11/20, 21:42
-
Markus Klein updated the commit message in patch set 3 03/11/20, 21:42
-
Markus Klein voted on patch set 3 CR +1 03/11/20, 21:42
-
TYPO3com voted on patch set 3 V -1 03/11/20, 21:55 Completed build in 12m 17s on Wed, 11 Mar, 09:55 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1268
-
TYPO3com voted on patch set 3 V +1 03/11/20, 22:19 Completed build in 11m 13s on Wed, 11 Mar, 10:19 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1269
-
Oli Bartsch voted on patch set 3 V +1 CR +1 03/12/20, 07:16
-
Stefan Froemken commented on patch set 3 V +1 CR +1 03/12/20, 07:30
I have tested it with various values. Yeah, works. -
Andreas Kienast voted on patch set 3 V +2 CR +2 03/12/20, 07:57
-
Andreas Kienast merged patch set 4 03/12/20, 07:58