Review main Merged

63686[BUGFIX] Provide inlineParentUid in FormInlineAjaxController

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 03/31/20, 09:41

Commit message

By expanding an inline record the AJAX request calls the `detailAction`
in `FormInlineAjaxController`. The parent data array created in this
function does not contain the parent record's uid nor its database row.

In order to ensure that the uid is not NULL, in any FormDataProvider,
the uid is now added to the parent data array. This value is then used
as fallback in case there is no database row given in the `compileChild`
function which calls the FormDataProviders.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Eßl +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1015

  1. Oli Bartsch uploaded patch set 1 03/11/20, 16:40

  2. Oli Bartsch updated the commit message in patch set 2 03/11/20, 16:41

  3. TYPO3com voted on patch set 1 V -1 03/11/20, 16:52 Completed build in 12m 12s on Wed, 11 Mar, 04:52 PM Test Summary: 1 of 72680 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1257

  4. TYPO3com voted on patch set 2 V +1 03/11/20, 16:59 Completed build in 15m 00s on Wed, 11 Mar, 04:59 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1258

  5. Oli Bartsch uploaded patch set 3 03/12/20, 07:07

  6. TYPO3com voted on patch set 3 V +1 03/12/20, 07:37 Completed build in 28m 27s on Thu, 12 Mar, 07:37 AM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1275

  7. Georg Ringer commented on patch set 3 CR -1 03/12/20, 08:55

    Unresolved

    value
  8. Oli Bartsch updated the commit message in patch set 4 03/12/20, 09:35

  9. TYPO3com voted on patch set 4 V -1 03/12/20, 09:48 Completed build in 12m 10s on Thu, 12 Mar, 09:48 AM Test Summary: 64592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1283

  10. TYPO3com voted on patch set 4 V +1 03/12/20, 13:03 Completed build in 12m 10s on Thu, 12 Mar, 01:03 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1286

  11. Benni Mack voted on patch set 4 CR +1 03/24/20, 16:54

  12. Christian Eßl voted on patch set 4 CR +1 03/27/20, 11:08

  13. Susi Moog voted on patch set 4 V +1 CR +1 03/27/20, 15:31

  14. Benni Mack voted on patch set 4 V +2 CR +2 03/31/20, 09:41

  15. Benni Mack merged patch set 5 03/31/20, 09:41