Review main Abandoned

63687[BUGFIX] Collapse all panels if search query is empty

Andreas Kienast CR 0 V 0 Easy +2 −2 updated 03/12/20, 06:36

Commit message

If the search in "View Upgrade Documentation" is emptied, all panels are
now collapsed again.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 57

  1. Andreas Kienast uploaded patch set 1 03/11/20, 20:56

  2. TYPO3com voted on patch set 1 V -1 03/11/20, 21:09 Completed build in 13m 13s on Wed, 11 Mar, 09:09 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1265

  3. Andreas Kienast uploaded patch set 2 03/11/20, 21:19

  4. TYPO3com voted on patch set 2 V +1 03/11/20, 21:41 Completed build in 16m 23s on Wed, 11 Mar, 09:41 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1267

  5. Riccardo De Contardi commented on patch set 2 03/11/20, 21:44

    tested with Master, it does not seem to work with the "x" icon that cleans the search field. To make it work I had to 1) Click on the "x" 2) click on the input field to focus on it again 3) click backspace
  6. Andreas Kienast commented on patch set 2 03/11/20, 21:48

    > Patch Set 2: > > tested with Master, it does not seem to work with the "x" icon that cleans the search field. > To make it work I had to > 1) Click on the "x" > 2) click on the input field to focus on it again > 3) click backspace Perhaps we need https://review.typo3.org/c/Packages/TYPO3.CMS/+/63688 as well. If this doesn't help, then the fix is obviously not sufficient.
  7. Andreas Kienast abandoned the change 03/12/20, 06:36

    I'll create one large bugfix as this module has several issues