Review main Merged

63688[BUGFIX] Fix various issues in "View Upgrade Docs"

Andreas Kienast CR +2 V +2 Easy +12 −10 updated 03/12/20, 07:52

Commit message

The search field was initialized twice which broke the clearable
feature. Since we don't like redundancy we omit a second initialization
and better do it right the first time.

If the search field is emptied after querying the docs, the original
state is recovered. All panels without exception are closed again.

When panels get collapsed, only expanded panels are queried which
improves the subjective performance of the process.

An unavailable function `.contains` was used to filter changelogs by
tags. Searching for a colon is now done via
`String.prototype.includes()`.

Any search action is now debounced to avoid massive DOM manipulations
due to excessive typing in the search field.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 1318

  1. Andreas Kienast uploaded patch set 1 03/11/20, 21:16

  2. TYPO3com voted on patch set 1 V +1 03/11/20, 21:35 Completed build in 18m 23s on Wed, 11 Mar, 09:35 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1266

  3. Georg Ringer commented on patch set 1 CR -1 03/11/20, 21:59

    the error is gone but another error is there after using the tag filter > t.contains is not a function
  4. Georg Ringer voted on patch set 1 V +1 CR +1 03/11/20, 22:02

  5. Andreas Kienast commented on patch set 1 CR -1 03/12/20, 06:36

    on it
  6. Andreas Kienast uploaded patch set 2 03/12/20, 06:54

  7. Andreas Kienast uploaded patch set 3 03/12/20, 07:04

  8. Susi Moog updated the commit message in patch set 4 03/12/20, 07:06

  9. Susi Moog voted on patch set 4 CR +1 03/12/20, 07:06

  10. TYPO3com voted on patch set 2 V +1 03/12/20, 07:08 Completed build in 14m 16s on Thu, 12 Mar, 07:08 AM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1272

  11. Andreas Kienast uploaded patch set 5 03/12/20, 07:09

  12. Georg Ringer voted on patch set 5 V +1 CR +1 03/12/20, 07:15

  13. Frank Nägler voted on patch set 5 CR +1 03/12/20, 07:26

  14. TYPO3com voted on patch set 3 V +1 03/12/20, 07:27 Completed build in 19m 14s on Thu, 12 Mar, 07:27 AM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1273

  15. TYPO3com voted on patch set 4 V +1 03/12/20, 07:33 Completed build in 24m 32s on Thu, 12 Mar, 07:33 AM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1274

  16. Frank Nägler voted on patch set 5 V +2 CR +2 03/12/20, 07:40

  17. TYPO3com voted on patch set 5 V +1 03/12/20, 07:51 Completed build in 24m 35s on Thu, 12 Mar, 07:51 AM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1276

  18. Frank Nägler merged patch set 6 03/12/20, 07:52