Review main Abandoned

63693[BUGFIX] Keep added items through ExtensionManagementUtility localizable

Georg Ringer CR 0 V 0 Easy +6 −2 updated 03/17/20, 21:36

Commit message

localizable

In ExtensionManagementUtility there are 2 methods which are a shorthand
method to modify the TCA:

* addStaticFile
* registerPageTSConfigFile

Both methods break the default behaviour of TYPO3 to have items
localizable because of appending text to the label. By checking if the
text starts with 'LLL' the strings can be translated again.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 1517

  1. Georg Ringer uploaded patch set 1 03/12/20, 12:34

  2. Georg Ringer commented on patch set 1 03/12/20, 12:35

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/12/20, 12:49 Completed build in 14m 23s on Thu, 12 Mar, 12:49 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1285

  4. Christian Eßl commented on patch set 1 03/12/20, 13:21

    ExtensionManagementUtility.php:1286 Unresolved

    I would recommend to check for 'LLL:'.
  5. Georg Ringer uploaded patch set 2 03/12/20, 13:31

  6. TYPO3com voted on patch set 2 V +1 03/12/20, 13:42 Completed build in 11m 25s on Thu, 12 Mar, 01:42 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1288

  7. Markus Klein commented on patch set 2 03/12/20, 14:28

    So if LLL is used, no extkey is appended anymore. I actually never needed those items to be translatable, I consider the extkey much more valuable.
  8. Georg Ringer commented on patch set 2 03/12/20, 15:44

    > Patch Set 2: > > So if LLL is used, no extkey is appended anymore. > I actually never needed those items to be translatable, I consider the extkey much more valuable. You can add this still to your lll and nothing changes. For integrators this is important to be translateable
  9. Andreas Kienast commented on patch set 2 V +1 CR -1 03/12/20, 17:51

    > Patch Set 2: > > [...] For integrators this is important to be translateable I don't get why this should clash with appending the extension key. The current behavior introduced with this patch creates an inconsistency we should avoid.
  10. Andreas Kienast commented on patch set 2 CR 0 03/12/20, 17:53

    > Patch Set 2: Verified+1 Code-Review-1 > > > Patch Set 2: > > > > [...] For integrators this is important to be translateable Now I see. You don't translate the label here, this is done by FormEngine in the lower levels. That's nasty indeed.
  11. Markus Klein commented on patch set 2 03/12/20, 19:32

    > Patch Set 2: -Code-Review > > > Patch Set 2: Verified+1 Code-Review-1 > > > > > Patch Set 2: > > > > > > [...] For integrators this is important to be translateable > > Now I see. You don't translate the label here, this is done by FormEngine in the lower levels. That's nasty indeed. Yes that's done by FormEngine, but still adding the extkey must be added by the ext-author now. This means inconsistency, which I really dislike in this regard. We either kick the extkey in general or we resolve the LLL here and add the extkey as ususal.
  12. Georg Ringer commented on patch set 2 03/12/20, 20:55

    > Yes that's done by FormEngine, but still adding the extkey must be added by the ext-author now. This means inconsistency, which I really dislike in this regard. > We either kick the extkey in general or we resolve the LLL here and add the extkey as ususal. we can't resolve the LLL here as this is cached in the TCA. and I did the extra check to have the consistency. It is fine for me if we do this in master only. And one last thing: this is just a wrapper for direct modification of the TCA, so if this patch can't be merged, I will just use the direct way which is fine as well
  13. Markus Klein commented on patch set 2 03/12/20, 21:14

    I'm not -1 to the patch. Don't get me wrong. And yes, it's a wrapper, but still an API we encourage to use. My point is only about the consistency, but I have no solution for the extkey either. I am just not sure why this needs to be translatable? An integrator needs to be capable of the English language otherwise he/she strands already with the first install wizard.
  14. Georg Ringer commented on patch set 2 03/14/20, 18:49

    > Patch Set 2: > An integrator needs to be capable of the English language otherwise he/she strands already with the first install wizard. which is a different problem but nothing should be english only
  15. Benni Mack commented on patch set 2 03/14/20, 21:33

    @Markus: 1. question is if we want to keep the extkey in there 2. If we want these items translateable at all
  16. Markus Klein commented on patch set 2 03/16/20, 08:02

    > Patch Set 2: > > @Markus: > 1. question is if we want to keep the extkey in there > 2. If we want these items translateable at all 1) I consider them really handy. 2) I actually don't see the necessity to translate the static includes. But that's my POV.
  17. Georg Ringer abandoned the change 03/17/20, 21:36

    abandoned, see issues for explanation